Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: Source/core/xml/XMLHttpRequest.cpp

Issue 585873002: Show a warning when using sync xhr. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/xml/XMLHttpRequest.cpp
diff --git a/Source/core/xml/XMLHttpRequest.cpp b/Source/core/xml/XMLHttpRequest.cpp
index 7fe4b47433d6a577db730aa2ccf75c78053f12e0..a901d2a4137b57fade5987ac6edd6063f52774d9 100644
--- a/Source/core/xml/XMLHttpRequest.cpp
+++ b/Source/core/xml/XMLHttpRequest.cpp
@@ -592,6 +592,12 @@ void XMLHttpRequest::open(const AtomicString& method, const KURL& url, bool asyn
exceptionState.throwDOMException(InvalidAccessError, "Synchronous requests must not set a timeout.");
return;
}
+
+ // Here we just warn that firing sync XHR's may affect responsiveness.
+ // Eventually sync xhr will be deprecated and an "InvalidAccessError" exception thrown.
+ // Refer : https://xhr.spec.whatwg.org/#sync-warning
+ executionContext()->addConsoleMessage(ConsoleMessage::create(JSMessageSource, WarningMessageLevel
+ , "Avoid synchronous requests as it hampers user experience due to unresponsiveness of the web page.Refer https://xhr.spec.whatwg.org/#sync-warning."));
tyoshino (SeeGerritForStatus) 2014/09/19 11:03:10 Insert a space between "page." and "Refer" Please
Mayur Kankanwadi 2014/09/19 11:24:17 Done.
}
m_method = uppercaseKnownHTTPMethod(method);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698