Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 585853003: Don't try to add large glyphs to the font atlas. (Closed)

Created:
6 years, 3 months ago by jvanverth1
Modified:
6 years, 3 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Don't try to add large glyphs to the font atlas. When the glyph data is invalid we can try to allocate a ridiculous amount of memory. This adds a check to cover such cases. BUG=414581 Committed: https://skia.googlesource.com/skia/+/681e65b19940e10f39bf1237b4b35aa94677b3d0

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -36 lines) Patch
M src/gpu/GrBitmapTextContext.cpp View 1 chunk +20 lines, -18 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 chunk +20 lines, -18 lines 0 comments Download
M src/gpu/GrTextStrike.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/GrTextStrike.cpp View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jvanverth1
6 years, 3 months ago (2014-09-19 19:40:04 UTC) #2
egdaniel
lgtm + possible comment https://codereview.chromium.org/585853003/diff/1/src/gpu/GrTextStrike.h File src/gpu/GrTextStrike.h (right): https://codereview.chromium.org/585853003/diff/1/src/gpu/GrTextStrike.h#newcode40 src/gpu/GrTextStrike.h:40: bool glyphTooLargeForAtlas(GrGlyph*); Maybe add comment ...
6 years, 3 months ago (2014-09-19 19:49:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585853003/20001
6 years, 3 months ago (2014-09-19 20:00:15 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 20:07:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 681e65b19940e10f39bf1237b4b35aa94677b3d0

Powered by Google App Engine
This is Rietveld 408576698