Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: net/disk_cache/disk_cache_test_base.cc

Issue 585833002: Revert of Remove void** from disk_cache interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/disk_cache/disk_cache_test_base.h ('k') | net/disk_cache/entry_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/disk_cache/disk_cache_test_base.cc
diff --git a/net/disk_cache/disk_cache_test_base.cc b/net/disk_cache/disk_cache_test_base.cc
index c3d94e6ac9ae30249444d35dd4e7aa3f21792852..d0f984256ad425113fb440d5b4fb4017b8e9cbe5 100644
--- a/net/disk_cache/disk_cache_test_base.cc
+++ b/net/disk_cache/disk_cache_test_base.cc
@@ -52,20 +52,6 @@
base::RunLoop().RunUntilIdle();
}
-DiskCacheTestWithCache::TestIterator::TestIterator(
- scoped_ptr<disk_cache::Backend::Iterator> iterator)
- : iterator_(iterator.Pass()) {
-}
-
-DiskCacheTestWithCache::TestIterator::~TestIterator() {}
-
-int DiskCacheTestWithCache::TestIterator::OpenNextEntry(
- disk_cache::Entry** next_entry) {
- net::TestCompletionCallback cb;
- int rv = iterator_->OpenNextEntry(next_entry, cb.callback());
- return cb.GetResult(rv);
-}
-
DiskCacheTestWithCache::DiskCacheTestWithCache()
: cache_impl_(NULL),
simple_cache_impl_(NULL),
@@ -167,9 +153,11 @@
return cb.GetResult(rv);
}
-scoped_ptr<DiskCacheTestWithCache::TestIterator>
- DiskCacheTestWithCache::CreateIterator() {
- return scoped_ptr<TestIterator>(new TestIterator(cache_->CreateIterator()));
+int DiskCacheTestWithCache::OpenNextEntry(void** iter,
+ disk_cache::Entry** next_entry) {
+ net::TestCompletionCallback cb;
+ int rv = cache_->OpenNextEntry(iter, next_entry, cb.callback());
+ return cb.GetResult(rv);
}
void DiskCacheTestWithCache::FlushQueueForTest() {
« no previous file with comments | « net/disk_cache/disk_cache_test_base.h ('k') | net/disk_cache/entry_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698