[Easy Unlock] Port the BluetoothConnection class to native code.

[Easy Unlock] Port the BluetoothConnection class to native code.

BUG=413488
TEST=components_unittests
R=tengs@chromium.org

Committed: https://crrev.com/83d08a29ec9d53c93f69a6a1cce75f5d736c5f75
Cr-Commit-Position: refs/heads/master@{#296872}

[Tim Song, 2014-09-22 23:30:39]

https://codereview.chromium.org/585743004/diff/20001/components/proximity_aut...
File components/proximity_auth/bluetooth_connection.cc (right):

https://codereview.chromium.org/585743004/diff/20001/components/proximity_aut...
components/proximity_auth/bluetooth_connection.cc:120: if (!bluetooth_device) {
Reading this code gave me the thought that it would be cleaner to put the
SeekDeviceByAddress flow here rather than in the ConnectionFinder. WDYT? If you
agree, feel free to do it in another CL.

https://codereview.chromium.org/585743004/diff/20001/components/proximity_aut...
File components/proximity_auth/bluetooth_connection_unittest.cc (right):

https://codereview.chromium.org/585743004/diff/20001/components/proximity_aut...
components/proximity_auth/bluetooth_connection_unittest.cc:113: void
BeginConnecting(MockBluetoothConnection* connection) {
check STATUS == DISCONNECTED

https://codereview.chromium.org/585743004/diff/20001/components/proximity_aut...
components/proximity_auth/bluetooth_connection_unittest.cc:115:
EXPECT_CALL(*adapter_, GetDevice(_)).WillOnce(Return(&device_));
use ON_CALL instead.

https://codereview.chromium.org/585743004/diff/20001/components/proximity_aut...
components/proximity_auth/bluetooth_connection_unittest.cc:118:
connection->Connect();
check status == CONNECTING

https://codereview.chromium.org/585743004/diff/20001/components/proximity_aut...
components/proximity_auth/bluetooth_connection_unittest.cc:125:
EXPECT_CALL(*adapter_, GetDevice(_)).WillOnce(Return(&device_));
use ON_CALL

https://codereview.chromium.org/585743004/diff/20001/components/proximity_aut...
components/proximity_auth/bluetooth_connection_unittest.cc:134:
callback.Run(socket_);
Check status == CONNECTED

https://codereview.chromium.org/585743004/diff/20001/components/proximity_aut...
components/proximity_auth/bluetooth_connection_unittest.cc:254:
connection.Connect();
Why not just use the ProximityAuthBluetoothConnectionTest::Connect() utility
function? There's a few more places below as well.

https://codereview.chromium.org/585743004/diff/20001/components/proximity_aut...
components/proximity_auth/bluetooth_connection_unittest.cc:412:
connection.Connect();
Why not use BeginConnection?

[Ilya Sherman, 2014-09-23 05:24:23]

https://chromiumcodereview.appspot.com/585743004/diff/20001/components/proxim...
File components/proximity_auth/bluetooth_connection.cc (right):

https://chromiumcodereview.appspot.com/585743004/diff/20001/components/proxim...
components/proximity_auth/bluetooth_connection.cc:120: if (!bluetooth_device) {
On 2014/09/22 23:30:38, Tim Song wrote:
> Reading this code gave me the thought that it would be cleaner to put the
> SeekDeviceByAddress flow here rather than in the ConnectionFinder. WDYT? If
you
> agree, feel free to do it in another CL.

Yeah, I think that makes sense.  I'll go ahead and implement that in a follow-up
CL.

https://chromiumcodereview.appspot.com/585743004/diff/20001/components/proxim...
File components/proximity_auth/bluetooth_connection_unittest.cc (right):

https://chromiumcodereview.appspot.com/585743004/diff/20001/components/proxim...
components/proximity_auth/bluetooth_connection_unittest.cc:113: void
BeginConnecting(MockBluetoothConnection* connection) {
On 2014/09/22 23:30:38, Tim Song wrote:
> check STATUS == DISCONNECTED

Done.

https://chromiumcodereview.appspot.com/585743004/diff/20001/components/proxim...
components/proximity_auth/bluetooth_connection_unittest.cc:115:
EXPECT_CALL(*adapter_, GetDevice(_)).WillOnce(Return(&device_));
On 2014/09/22 23:30:39, Tim Song wrote:
> use ON_CALL instead.

Done.

https://chromiumcodereview.appspot.com/585743004/diff/20001/components/proxim...
components/proximity_auth/bluetooth_connection_unittest.cc:118:
connection->Connect();
On 2014/09/22 23:30:38, Tim Song wrote:
> check status == CONNECTING

Done.

https://chromiumcodereview.appspot.com/585743004/diff/20001/components/proxim...
components/proximity_auth/bluetooth_connection_unittest.cc:125:
EXPECT_CALL(*adapter_, GetDevice(_)).WillOnce(Return(&device_));
On 2014/09/22 23:30:39, Tim Song wrote:
> use ON_CALL

Done.

https://chromiumcodereview.appspot.com/585743004/diff/20001/components/proxim...
components/proximity_auth/bluetooth_connection_unittest.cc:134:
callback.Run(socket_);
On 2014/09/22 23:30:39, Tim Song wrote:
> Check status == CONNECTED

Done.

https://chromiumcodereview.appspot.com/585743004/diff/20001/components/proxim...
components/proximity_auth/bluetooth_connection_unittest.cc:254:
connection.Connect();
On 2014/09/22 23:30:38, Tim Song wrote:
> Why not just use the ProximityAuthBluetoothConnectionTest::Connect() utility
> function? There's a few more places below as well.

Because we need to save a reference to the callback, which the Connect()
function doesn't do.  I tried to use the Connect() function everywhere that
wasn't specifically testing details of the connection process.

https://chromiumcodereview.appspot.com/585743004/diff/20001/components/proxim...
components/proximity_auth/bluetooth_connection_unittest.cc:412:
connection.Connect();
On 2014/09/22 23:30:38, Tim Song wrote:
> Why not use BeginConnection?

Same as before: We need to save a reference to the callback.

[Tim Song, 2014-09-23 21:22:12]

https://codereview.chromium.org/585743004/diff/20001/components/proximity_aut...
File components/proximity_auth/bluetooth_connection_unittest.cc (right):

https://codereview.chromium.org/585743004/diff/20001/components/proximity_aut...
components/proximity_auth/bluetooth_connection_unittest.cc:254:
connection.Connect();
On 2014/09/23 05:24:22, Ilya Sherman wrote:
> On 2014/09/22 23:30:38, Tim Song wrote:
> > Why not just use the ProximityAuthBluetoothConnectionTest::Connect() utility
> > function? There's a few more places below as well.
> 
> Because we need to save a reference to the callback, which the Connect()
> function doesn't do.  I tried to use the Connect() function everywhere that
> wasn't specifically testing details of the connection process.

I don't understand. This function is almost line-by-line the same as Connect().
Also, if you need the callback, why not have Connect return it?

[Ilya Sherman, 2014-09-23 22:07:07]

https://codereview.chromium.org/585743004/diff/20001/components/proximity_aut...
File components/proximity_auth/bluetooth_connection_unittest.cc (right):

https://codereview.chromium.org/585743004/diff/20001/components/proximity_aut...
components/proximity_auth/bluetooth_connection_unittest.cc:254:
connection.Connect();
On 2014/09/23 21:22:12, Tim Song wrote:
> On 2014/09/23 05:24:22, Ilya Sherman wrote:
> > On 2014/09/22 23:30:38, Tim Song wrote:
> > > Why not just use the ProximityAuthBluetoothConnectionTest::Connect()
utility
> > > function? There's a few more places below as well.
> > 
> > Because we need to save a reference to the callback, which the Connect()
> > function doesn't do.  I tried to use the Connect() function everywhere that
> > wasn't specifically testing details of the connection process.
> 
> I don't understand. This function is almost line-by-line the same as
Connect().
> Also, if you need the callback, why not have Connect return it?

Hmm, I suppose you're right.  Okay, I've updated this test as well as the three
below to use the Connect() utility function.  Note that I ended up adding an
additional, more complex, utility function for connecting and saving callbacks. 
Let me know if you think that's worth it, or if it's overly complex.

[Tim Song, 2014-09-24 01:15:40]

lgtm

https://codereview.chromium.org/585743004/diff/80001/components/proximity_aut...
File components/proximity_auth/bluetooth_connection_unittest.cc (right):

https://codereview.chromium.org/585743004/diff/80001/components/proximity_aut...
components/proximity_auth/bluetooth_connection_unittest.cc:133: void
ConnectAndCaptureReceiveCallbacks(
It might be more readable to just save these callbacks as member variables and
expose ReceiveOnSocket/ReceiveOnSocketError functions.

[Ilya Sherman, 2014-09-26 02:22:48]

https://codereview.chromium.org/585743004/diff/80001/components/proximity_aut...
File components/proximity_auth/bluetooth_connection_unittest.cc (right):

https://codereview.chromium.org/585743004/diff/80001/components/proximity_aut...
components/proximity_auth/bluetooth_connection_unittest.cc:133: void
ConnectAndCaptureReceiveCallbacks(
On 2014/09/24 01:15:40, Tim Song wrote:
> It might be more readable to just save these callbacks as member variables and
> expose ReceiveOnSocket/ReceiveOnSocketError functions.

Done.

[Ilya Sherman, 2014-09-26 02:23:24]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-09-26 02:23:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/585743004/120001

[commit-bot: I haz the power, 2014-09-26 03:32:53]

Committed patchset #7 (id:120001) as 95cd153bac5da60362d211a021c5283a7c4f10fb

[commit-bot: I haz the power, 2014-09-26 03:33:28]

Patchset 7 (id:??) landed as
https://crrev.com/83d08a29ec9d53c93f69a6a1cce75f5d736c5f75
Cr-Commit-Position: refs/heads/master@{#296872}