Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1571)

Unified Diff: Source/core/rendering/RenderInline.cpp

Issue 585743003: Move paint code from RenderInline into InlinePainter. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Merged. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderInline.h ('k') | Source/core/rendering/RenderLineBoxList.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderInline.cpp
diff --git a/Source/core/rendering/RenderInline.cpp b/Source/core/rendering/RenderInline.cpp
index 3dd201d4e5476bb7185eb08346151c026cebd6d3..0e4bf7130af1eb0f90425a81a29aca3cd270ba65 100644
--- a/Source/core/rendering/RenderInline.cpp
+++ b/Source/core/rendering/RenderInline.cpp
@@ -28,6 +28,7 @@
#include "core/page/Chrome.h"
#include "core/page/Page.h"
#include "core/paint/BoxPainter.h"
+#include "core/paint/InlinePainter.h"
#include "core/paint/ObjectPainter.h"
#include "core/rendering/GraphicsContextAnnotator.h"
#include "core/rendering/HitTestResult.h"
@@ -554,8 +555,7 @@ void RenderInline::addChildToContinuation(RenderObject* newChild, RenderObject*
void RenderInline::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffset)
{
- ANNOTATE_GRAPHICS_CONTEXT(paintInfo, this);
- m_lineBoxes.paint(this, paintInfo, paintOffset);
+ InlinePainter(*this).paint(paintInfo, paintOffset);
}
template<typename GeneratorContext>
@@ -1408,161 +1408,6 @@ void RenderInline::computeSelfHitTestRects(Vector<LayoutRect>& rects, const Layo
generateLineBoxRects(context);
}
-void RenderInline::paintOutline(PaintInfo& paintInfo, const LayoutPoint& paintOffset)
-{
- RenderStyle* styleToUse = style();
- if (!styleToUse->hasOutline())
- return;
-
- if (styleToUse->outlineStyleIsAuto()) {
- if (RenderTheme::theme().shouldDrawDefaultFocusRing(this)) {
- // Only paint the focus ring by hand if the theme isn't able to draw the focus ring.
- ObjectPainter(*this).paintFocusRing(paintInfo, paintOffset, styleToUse);
- }
- return;
- }
-
- if (styleToUse->outlineStyle() == BNONE)
- return;
-
- Vector<LayoutRect> rects;
-
- rects.append(LayoutRect());
- for (InlineFlowBox* curr = firstLineBox(); curr; curr = curr->nextLineBox()) {
- RootInlineBox& root = curr->root();
- LayoutUnit top = std::max<LayoutUnit>(root.lineTop(), curr->logicalTop());
- LayoutUnit bottom = std::min<LayoutUnit>(root.lineBottom(), curr->logicalBottom());
- rects.append(LayoutRect(curr->x(), top, curr->logicalWidth(), bottom - top));
- }
- rects.append(LayoutRect());
-
- Color outlineColor = resolveColor(styleToUse, CSSPropertyOutlineColor);
- bool useTransparencyLayer = outlineColor.hasAlpha();
-
- GraphicsContext* graphicsContext = paintInfo.context;
- if (useTransparencyLayer) {
- graphicsContext->beginTransparencyLayer(static_cast<float>(outlineColor.alpha()) / 255);
- outlineColor = Color(outlineColor.red(), outlineColor.green(), outlineColor.blue());
- }
-
- for (unsigned i = 1; i < rects.size() - 1; i++)
- paintOutlineForLine(graphicsContext, paintOffset, rects.at(i - 1), rects.at(i), rects.at(i + 1), outlineColor);
-
- if (useTransparencyLayer)
- graphicsContext->endLayer();
-}
-
-void RenderInline::paintOutlineForLine(GraphicsContext* graphicsContext, const LayoutPoint& paintOffset,
- const LayoutRect& lastline, const LayoutRect& thisline, const LayoutRect& nextline,
- const Color outlineColor)
-{
- RenderStyle* styleToUse = style();
- int outlineWidth = styleToUse->outlineWidth();
- EBorderStyle outlineStyle = styleToUse->outlineStyle();
-
- bool antialias = BoxPainter::shouldAntialiasLines(graphicsContext);
-
- int offset = style()->outlineOffset();
-
- LayoutRect box(LayoutPoint(paintOffset.x() + thisline.x() - offset, paintOffset.y() + thisline.y() - offset),
- LayoutSize(thisline.width() + offset, thisline.height() + offset));
-
- IntRect pixelSnappedBox = pixelSnappedIntRect(box);
- if (pixelSnappedBox.width() < 0 || pixelSnappedBox.height() < 0)
- return;
- IntRect pixelSnappedLastLine = pixelSnappedIntRect(paintOffset.x() + lastline.x(), 0, lastline.width(), 0);
- IntRect pixelSnappedNextLine = pixelSnappedIntRect(paintOffset.x() + nextline.x(), 0, nextline.width(), 0);
-
- // left edge
- ObjectPainter::drawLineForBoxSide(graphicsContext,
- pixelSnappedBox.x() - outlineWidth,
- pixelSnappedBox.y() - (lastline.isEmpty() || thisline.x() < lastline.x() || (lastline.maxX() - 1) <= thisline.x() ? outlineWidth : 0),
- pixelSnappedBox.x(),
- pixelSnappedBox.maxY() + (nextline.isEmpty() || thisline.x() <= nextline.x() || (nextline.maxX() - 1) <= thisline.x() ? outlineWidth : 0),
- BSLeft,
- outlineColor, outlineStyle,
- (lastline.isEmpty() || thisline.x() < lastline.x() || (lastline.maxX() - 1) <= thisline.x() ? outlineWidth : -outlineWidth),
- (nextline.isEmpty() || thisline.x() <= nextline.x() || (nextline.maxX() - 1) <= thisline.x() ? outlineWidth : -outlineWidth),
- antialias);
-
- // right edge
- ObjectPainter::drawLineForBoxSide(graphicsContext,
- pixelSnappedBox.maxX(),
- pixelSnappedBox.y() - (lastline.isEmpty() || lastline.maxX() < thisline.maxX() || (thisline.maxX() - 1) <= lastline.x() ? outlineWidth : 0),
- pixelSnappedBox.maxX() + outlineWidth,
- pixelSnappedBox.maxY() + (nextline.isEmpty() || nextline.maxX() <= thisline.maxX() || (thisline.maxX() - 1) <= nextline.x() ? outlineWidth : 0),
- BSRight,
- outlineColor, outlineStyle,
- (lastline.isEmpty() || lastline.maxX() < thisline.maxX() || (thisline.maxX() - 1) <= lastline.x() ? outlineWidth : -outlineWidth),
- (nextline.isEmpty() || nextline.maxX() <= thisline.maxX() || (thisline.maxX() - 1) <= nextline.x() ? outlineWidth : -outlineWidth),
- antialias);
- // upper edge
- if (thisline.x() < lastline.x())
- ObjectPainter::drawLineForBoxSide(graphicsContext,
- pixelSnappedBox.x() - outlineWidth,
- pixelSnappedBox.y() - outlineWidth,
- std::min(pixelSnappedBox.maxX() + outlineWidth, (lastline.isEmpty() ? 1000000 : pixelSnappedLastLine.x())),
- pixelSnappedBox.y(),
- BSTop, outlineColor, outlineStyle,
- outlineWidth,
- (!lastline.isEmpty() && paintOffset.x() + lastline.x() + 1 < pixelSnappedBox.maxX() + outlineWidth) ? -outlineWidth : outlineWidth,
- antialias);
-
- if (lastline.maxX() < thisline.maxX())
- ObjectPainter::drawLineForBoxSide(graphicsContext,
- std::max(lastline.isEmpty() ? -1000000 : pixelSnappedLastLine.maxX(), pixelSnappedBox.x() - outlineWidth),
- pixelSnappedBox.y() - outlineWidth,
- pixelSnappedBox.maxX() + outlineWidth,
- pixelSnappedBox.y(),
- BSTop, outlineColor, outlineStyle,
- (!lastline.isEmpty() && pixelSnappedBox.x() - outlineWidth < paintOffset.x() + lastline.maxX()) ? -outlineWidth : outlineWidth,
- outlineWidth, antialias);
-
- if (thisline.x() == thisline.maxX())
- ObjectPainter::drawLineForBoxSide(graphicsContext,
- pixelSnappedBox.x() - outlineWidth,
- pixelSnappedBox.y() - outlineWidth,
- pixelSnappedBox.maxX() + outlineWidth,
- pixelSnappedBox.y(),
- BSTop, outlineColor, outlineStyle,
- outlineWidth,
- outlineWidth,
- antialias);
-
- // lower edge
- if (thisline.x() < nextline.x())
- ObjectPainter::drawLineForBoxSide(graphicsContext,
- pixelSnappedBox.x() - outlineWidth,
- pixelSnappedBox.maxY(),
- std::min(pixelSnappedBox.maxX() + outlineWidth, !nextline.isEmpty() ? pixelSnappedNextLine.x() + 1 : 1000000),
- pixelSnappedBox.maxY() + outlineWidth,
- BSBottom, outlineColor, outlineStyle,
- outlineWidth,
- (!nextline.isEmpty() && paintOffset.x() + nextline.x() + 1 < pixelSnappedBox.maxX() + outlineWidth) ? -outlineWidth : outlineWidth,
- antialias);
-
- if (nextline.maxX() < thisline.maxX())
- ObjectPainter::drawLineForBoxSide(graphicsContext,
- std::max(!nextline.isEmpty() ? pixelSnappedNextLine.maxX() : -1000000, pixelSnappedBox.x() - outlineWidth),
- pixelSnappedBox.maxY(),
- pixelSnappedBox.maxX() + outlineWidth,
- pixelSnappedBox.maxY() + outlineWidth,
- BSBottom, outlineColor, outlineStyle,
- (!nextline.isEmpty() && pixelSnappedBox.x() - outlineWidth < paintOffset.x() + nextline.maxX()) ? -outlineWidth : outlineWidth,
- outlineWidth, antialias);
-
- if (thisline.x() == thisline.maxX())
- ObjectPainter::drawLineForBoxSide(graphicsContext,
- pixelSnappedBox.x() - outlineWidth,
- pixelSnappedBox.maxY(),
- pixelSnappedBox.maxX() + outlineWidth,
- pixelSnappedBox.maxY() + outlineWidth,
- BSBottom, outlineColor, outlineStyle,
- outlineWidth,
- outlineWidth,
- antialias);
-}
-
void RenderInline::addAnnotatedRegions(Vector<AnnotatedRegionValue>& regions)
{
// Convert the style regions to absolute coordinates.
« no previous file with comments | « Source/core/rendering/RenderInline.h ('k') | Source/core/rendering/RenderLineBoxList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698