Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2324)

Unified Diff: build/config/compiler/BUILD.gn

Issue 585693002: Drop -fno-slp-vectorize from the Clang build -- gn edition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index a1f54d74613a8c1f18f35ef964b90ba7f30283dc..599490da52894322313627f70ddb7e1c8ce52ea2 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -105,23 +105,15 @@ config("compiler") {
}
}
- if (is_clang) {
- cflags += [
- # TODO(thakis): Remove once http://llvm.org/PR20354 is fixed
- # and the fix is in chromium.
- "-fno-slp-vectorize",
+ if (is_clang && is_debug) {
+ # Allow comparing the address of references and 'this' against 0
+ # in debug builds. Technically, these can never be null in
+ # well-defined C/C++ and Clang can optimize such checks away in
+ # release builds, but they may be used in asserts in debug builds.
+ cflags_cc += [
+ "-Wno-undefined-bool-conversion",
+ "-Wno-tautological-undefined-compare",
]
-
- if (is_debug) {
- # Allow comparing the address of references and 'this' against 0
- # in debug builds. Technically, these can never be null in
- # well-defined C/C++ and Clang can optimize such checks away in
- # release builds, but they may be used in asserts in debug builds.
- cflags_cc += [
- "-Wno-undefined-bool-conversion",
- "-Wno-tautological-undefined-compare",
- ]
- }
}
if (is_clang && !is_win) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698