Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 585673002: More fixes to make 32 bit Linux builds pass compile. (Closed)

Created:
6 years, 3 months ago by jam
Modified:
6 years, 3 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

More fixes to make 32 bit Linux builds pass compile. This is breaking after r295514 which enforces that every file listed in an isolate file exists. BUG=414808 R=erg@chromium.org Committed: https://crrev.com/295a1b1a7514a50070ca717abe2df0a90b46c6c9 Cr-Commit-Position: refs/heads/master@{#295589}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M chrome/browser_tests.isolate View 1 chunk +6 lines, -0 lines 0 comments Download
M testing/chromoting/chromoting_integration_tests.isolate View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
6 years, 3 months ago (2014-09-18 22:59:23 UTC) #1
Elliot Glaysher
lgtm
6 years, 3 months ago (2014-09-18 23:01:25 UTC) #2
jam
Committed patchset #1 (id:1) manually as 295a1b1 (presubmit successful).
6 years, 3 months ago (2014-09-18 23:03:12 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 23:03:18 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/295a1b1a7514a50070ca717abe2df0a90b46c6c9
Cr-Commit-Position: refs/heads/master@{#295589}

Powered by Google App Engine
This is Rietveld 408576698