Issue 585653003: Fixed regression in "Save To Pdf" of Print Preview.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 585653003: Fixed regression in "Save To Pdf" of Print Preview. (Closed)

Created:
6 years, 3 months ago by Vitaly Buka (NO REVIEWS)

Modified:
6 years, 3 months ago

Reviewers:
gene

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Fixed regression in "Save To Pdf" of Print Preview. Logical OR was used instead of bitwise OR. BUG=415437 Committed: https://crrev.com/51b00db23ebec5f5d2f60ba756f681d70f5d25c8 Cr-Commit-Position: refs/heads/master@{#295588}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/ui/webui/print_preview/print_preview_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585653003/1

6 years, 3 months ago (2014-09-18 21:38:47 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as ed08f9d4fc870f56d8f75f9a8ccaddff9318ad57

6 years, 3 months ago (2014-09-18 22:58:51 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-18 22:59:25 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/51b00db23ebec5f5d2f60ba756f681d70f5d25c8
Cr-Commit-Position: refs/heads/master@{#295588}