After locking a profile and showing the User Manager, make Guest the active profile

chrome/browser/ui/cocoa/profiles/user_manager_mac.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/profiles/user_manager_mac.h"
 
 #include "chrome/app/chrome_command_ids.h"
+#import "chrome/browser/app_controller_mac.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/profiles/profiles_state.h"
 #include "chrome/browser/ui/browser_dialogs.h"
 #import "chrome/browser/ui/cocoa/browser_window_utils.h"
 #include "chrome/browser/ui/cocoa/chrome_event_processing_window.h"
 #include "chrome/grit/chromium_strings.h"
 #include "content/public/browser/native_web_keyboard_event.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_delegate.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 
 // Default window size. Taken from the views implementation in
@@ skipping 117 matching lines @@
 }
 
 - (void)showURL:(const GURL&)url {
   webContents_->GetController().LoadURL(url, content::Referrer(),
                                         content::PAGE_TRANSITION_AUTO_TOPLEVEL,
                                         std::string());
   [self show];
 }
 
 - (void)show {
+  // Because the User Manager isn't a BrowserWindowController, activating it
+  // will not trigger a -windowChangedToProfile and update the menu bar.
+  // This is only important if the active profile is Guest, which may have
+  // happened after locking a profile.

[Alexei Svitkine (slow), 2014/09/19 15:33:37]

Is it possible to lock a profile after this window is shown?

If so, wouldn't this logic have to exist elsewhere too? (If it's already handled
somewhere, please expand the comment to mention how that works.)

[noms (inactive), 2014/09/22 15:39:45]

Yes. You could leave this window open (it's not modal), and lock a different
profile. That would trigger the code in UserManagerMac::Show where the instance
exists, and we still call the UserManagerWindowController -show method here. 

I am not sure whether this is relevant to this comment -- whether you activate
the window or create it from scratch, you still end up in this function.

On 2014/09/19 15:33:37, Alexei Svitkine wrote:

+  profiles::SetActiveProfileToGuestIfLocked();
+  Profile* activeProfile = ProfileManager::GetLastUsedProfile();
+  if (activeProfile->IsGuestSession()) {
+    AppController* controller = [NSApp delegate];

[Alexei Svitkine (slow), 2014/09/19 15:33:36]

Use base::mac::ObjCCast<AppController>() instead of an implicit cast.

[noms (inactive), 2014/09/22 15:39:45]

Done.

+    [controller windowChangedToProfile:activeProfile];
+  }
   [[self window] makeKeyAndOrderFront:self];
 }
 
 - (void)close {
   [[self window] close];
 }
 
 -(BOOL)isVisible {
   return [[self window] isVisible];
 }
@@ skipping 49 matching lines @@
 void UserManagerMac::OnGuestProfileCreated(Profile* guest_profile,
                                            const std::string& url) {
   instance_ = new UserManagerMac(guest_profile);
   [instance_->window_controller_ showURL:GURL(url)];
 }
 
 void UserManagerMac::WindowWasClosed() {
   instance_ = NULL;
   delete this;
 }