Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 585633002: Rename BreakpadClient to CrashReporterClient. (Closed)

Created:
6 years, 3 months ago by Robert Sesek
Modified:
6 years, 3 months ago
CC:
ben+ash_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, kalyank, mkwst+moarreviews-shell_chromium.org, native-client-reviews_googlegroups.com, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename BreakpadClient to CrashReporterClient. BUG=406410 R=jochen@chromium.org Committed: https://crrev.com/a0a7a045d1d3cba7c7cdf925373e285eb697a5db Cr-Commit-Position: refs/heads/master@{#295612}

Patch Set 1 #

Patch Set 2 : Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+338 lines, -1098 lines) Patch
D chrome/app/chrome_breakpad_client.h View 1 chunk +0 lines, -77 lines 0 comments Download
D chrome/app/chrome_breakpad_client.cc View 1 chunk +0 lines, -377 lines 0 comments Download
D chrome/app/chrome_breakpad_client_mac.mm View 1 chunk +0 lines, -59 lines 0 comments Download
A + chrome/app/chrome_crash_reporter_client.h View 2 chunks +10 lines, -10 lines 0 comments Download
A + chrome/app/chrome_crash_reporter_client.cc View 14 chunks +31 lines, -26 lines 0 comments Download
A + chrome/app/chrome_crash_reporter_client_mac.mm View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/app/client_util.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/chrome_exe.gypi View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/nacl/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/nacl/nacl_exe_win_64.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/base/chrome_test_launcher.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M components/crash.gypi View 3 chunks +6 lines, -6 lines 0 comments Download
M components/crash/app/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
D components/crash/app/breakpad_client.h View 1 chunk +0 lines, -143 lines 0 comments Download
D components/crash/app/breakpad_client.cc View 1 chunk +0 lines, -127 lines 0 comments Download
M components/crash/app/breakpad_linux.cc View 9 chunks +14 lines, -12 lines 0 comments Download
M components/crash/app/breakpad_mac.mm View 6 chunks +11 lines, -8 lines 0 comments Download
M components/crash/app/breakpad_win.cc View 14 chunks +23 lines, -18 lines 0 comments Download
M components/crash/app/crash_keys_win.h View 3 chunks +7 lines, -5 lines 0 comments Download
M components/crash/app/crash_keys_win.cc View 4 chunks +10 lines, -11 lines 0 comments Download
M components/crash/app/crash_keys_win_unittest.cc View 1 5 chunks +8 lines, -8 lines 0 comments Download
A + components/crash/app/crash_reporter_client.h View 5 chunks +19 lines, -18 lines 0 comments Download
A components/crash/app/crash_reporter_client.cc View 1 chunk +129 lines, -0 lines 0 comments Download
M components/crash/app/hard_error_handler_win.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/content_shell.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
D content/shell/app/shell_breakpad_client.h View 1 chunk +0 lines, -55 lines 0 comments Download
D content/shell/app/shell_breakpad_client.cc View 1 chunk +0 lines, -72 lines 0 comments Download
A + content/shell/app/shell_crash_reporter_client.h View 2 chunks +9 lines, -9 lines 0 comments Download
A + content/shell/app/shell_crash_reporter_client.cc View 4 chunks +11 lines, -10 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Robert Sesek
6 years, 3 months ago (2014-09-18 21:52:40 UTC) #1
jochen (gone - plz use gerrit)
rs lgtm
6 years, 3 months ago (2014-09-18 21:58:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585633002/20001
6 years, 3 months ago (2014-09-18 22:08:07 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001) as bdd3802d6679768e20bac75807b40d952074ba03
6 years, 3 months ago (2014-09-18 23:59:34 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 00:00:24 UTC) #6
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a0a7a045d1d3cba7c7cdf925373e285eb697a5db
Cr-Commit-Position: refs/heads/master@{#295612}

Powered by Google App Engine
This is Rietveld 408576698