Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 585593002: Revert of Roll ANGLE. (Closed)

Created:
6 years, 3 months ago by Ian Vollick
Modified:
6 years, 3 months ago
Reviewers:
Geoff Lang, vmiura
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll ANGLE. (patchset #1 id:1 of https://codereview.chromium.org/579903002/) Reason for revert: Appears to be causing build failures. Here's an example. http://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Win%20Builder%20%28dbg%29/builds/12428/steps/steps/logs/stdio Original issue's description: > Roll ANGLE. > > Contains fixes for setting sampler uniforms. > > BUG=414450 > > Committed: https://crrev.com/ee4fc3e3db62b0a19e39f575b8faecd2dcc2f88b > Cr-Commit-Position: refs/heads/master@{#295519} TBR=vmiura@chromium.org,geofflang@chromium.org NOTREECHECKS=true NOTRY=true BUG=414450 Committed: https://crrev.com/66f40ead1d9e843856e8f251e50d03d1ea4c6f5a Cr-Commit-Position: refs/heads/master@{#295529}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ian Vollick
Created Revert of Roll ANGLE.
6 years, 3 months ago (2014-09-18 19:36:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585593002/1
6 years, 3 months ago (2014-09-18 19:38:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as e396f5f3b7bde938dba732f8ea2ccc2c6d7e3dba
6 years, 3 months ago (2014-09-18 19:39:47 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 19:40:56 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66f40ead1d9e843856e8f251e50d03d1ea4c6f5a
Cr-Commit-Position: refs/heads/master@{#295529}

Powered by Google App Engine
This is Rietveld 408576698