Fix case-sensitivity problems in extension content verification

extensions/browser/verified_contents.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_VERIFIED_CONTENTS_H_
 #define EXTENSIONS_BROWSER_VERIFIED_CONTENTS_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 28 matching lines @@
   // |path| and validated the enclosed signature. The
   // |ignore_invalid_signature| argument can be set to make this still succeed
   // if the contents of the file were parsed successfully but the signature did
   // not validate. (Use with caution!)
   bool InitFrom(const base::FilePath& path, bool ignore_invalid_signature);
 
   int block_size() const { return block_size_; }
   const std::string& extension_id() const { return extension_id_; }
   const base::Version& version() const { return version_; }
 
-  // This returns a pointer to the binary form of an expected sha256 root hash
-  // for |relative_path| computing using a tree hash algorithm.
-  const std::string* GetTreeHashRoot(const base::FilePath& relative_path);
+  bool HasTreeHashRoot(const base::FilePath& relative_path) const;
+
+  bool TreeHashRootEquals(const base::FilePath& relative_path,
+                          const std::string& expected) const;
 
   // If InitFrom has not been called yet, or was used in "ignore invalid
   // signature" mode, this can return false.
   bool valid_signature() { return valid_signature_; }
 
  private:
   // Returns the base64url-decoded "payload" field from the json at |path|, if
   // the signature was valid (or ignore_invalid_signature was set to true).
   bool GetPayload(const base::FilePath& path,
                   std::string* payload,
@@ skipping 14 matching lines @@
   // Indicates whether the signature was successfully validated or not.
   bool valid_signature_;
 
   // The block size used for computing the treehash root hashes.
   int block_size_;
 
   // Information about which extension these signed hashes are for.
   std::string extension_id_;
   base::Version version_;
 
-  // The expected treehash root hashes for each file.
-  std::map<base::FilePath, std::string> root_hashes_;
+  // The expected treehash root hashes for each file, lower cased so we can do
+  // case-insensitive lookups.
+  //
+  // We use a multi-map here so that we can do fast lookups of paths from
+  // requests on case-insensitive systems (windows, mac) where the request path
+  // might not have the exact right capitalization, but not break
+  // case-sensitive systems (linux, chromeos). TODO(asargent) - we should give
+  // developers client-side warnings in each of those cases, and have the
+  // webstore reject the cases they can statically detect. See crbug.com/29941
+  typedef std::multimap<base::FilePath::StringType, std::string> RootHashes;
+  RootHashes root_hashes_;
 
   DISALLOW_COPY_AND_ASSIGN(VerifiedContents);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_VERIFIED_CONTENTS_H_