Layout test to test that video should not be in a paused state while looping

Layout test to test that video should not be in a paused state while looping

TEST=this!
BUG=415651
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182519

[qinmin, 2014-09-18 18:04:56]

qinmin@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[qinmin, 2014-09-18 18:04:56]

PTAL

[DaleCurtis, 2014-09-18 18:16:27]

Please write this test using testharness.js, here's one I'm working on
currently:

https://codereview.chromium.org/544173012/

Note that no expectation file is required.

[qinmin, 2014-09-18 19:38:40]

Patchset #2 (id:20001) has been deleted

[qinmin, 2014-09-18 19:39:45]

Patchset #2 (id:40001) has been deleted

[qinmin, 2014-09-18 19:40:21]

On 2014/09/18 18:16:27, DaleCurtis wrote:
> Please write this test using testharness.js, here's one I'm working on
> currently:
> 
> https://codereview.chromium.org/544173012/
> 
> Note that no expectation file is required.

Done, switched to testharness.js

[DaleCurtis, 2014-09-18 19:44:47]

https://codereview.chromium.org/585563003/diff/60001/LayoutTests/media/video-...
File LayoutTests/media/video-not-paused-while-looping.html (right):

https://codereview.chromium.org/585563003/diff/60001/LayoutTests/media/video-...
LayoutTests/media/video-not-paused-while-looping.html:10: var video =
document.querySelector('video');
Note two spaces is okay per the style guide, but up to you.

https://codereview.chromium.org/585563003/diff/60001/LayoutTests/media/video-...
LayoutTests/media/video-not-paused-while-looping.html:29: video.onloadeddata =
test.step_func(function() {
Be consistent about {} placement. I prefer this style versus what you have
above, but the style guide says its up to you.

https://codereview.chromium.org/585563003/diff/60001/LayoutTests/media/video-...
LayoutTests/media/video-not-paused-while-looping.html:29: video.onloadeddata =
test.step_func(function() {
Move this above setting .src or you have a race.

[qinmin, 2014-09-18 20:40:41]

https://codereview.chromium.org/585563003/diff/60001/LayoutTests/media/video-...
File LayoutTests/media/video-not-paused-while-looping.html (right):

https://codereview.chromium.org/585563003/diff/60001/LayoutTests/media/video-...
LayoutTests/media/video-not-paused-while-looping.html:10: var video =
document.querySelector('video');
On 2014/09/18 19:44:47, DaleCurtis wrote:
> Note two spaces is okay per the style guide, but up to you.

Done.

https://codereview.chromium.org/585563003/diff/60001/LayoutTests/media/video-...
LayoutTests/media/video-not-paused-while-looping.html:29: video.onloadeddata =
test.step_func(function() {
On 2014/09/18 19:44:47, DaleCurtis wrote:
> Move this above setting .src or you have a race.

Done.

https://codereview.chromium.org/585563003/diff/60001/LayoutTests/media/video-...
LayoutTests/media/video-not-paused-while-looping.html:29: video.onloadeddata =
test.step_func(function() {
On 2014/09/18 19:44:47, DaleCurtis wrote:
> Be consistent about {} placement. I prefer this style versus what you have
> above, but the style guide says its up to you.

Done.

[DaleCurtis, 2014-09-19 01:02:36]

lgtm

https://codereview.chromium.org/585563003/diff/20002/LayoutTests/media/video-...
File LayoutTests/media/video-not-paused-while-looping.html (right):

https://codereview.chromium.org/585563003/diff/20002/LayoutTests/media/video-...
LayoutTests/media/video-not-paused-while-looping.html:22:
assert_equals(video.currentTime, 0, 'currentTime');
Hmm, this seems like it could be fragile.  I'd just check the paused state.

[qinmin, 2014-09-19 17:35:20]

https://codereview.chromium.org/585563003/diff/20002/LayoutTests/media/video-...
File LayoutTests/media/video-not-paused-while-looping.html (right):

https://codereview.chromium.org/585563003/diff/20002/LayoutTests/media/video-...
LayoutTests/media/video-not-paused-while-looping.html:22:
assert_equals(video.currentTime, 0, 'currentTime');
On 2014/09/19 01:02:36, DaleCurtis wrote:
> Hmm, this seems like it could be fragile.  I'd just check the paused state.

Done.

[qinmin, 2014-09-19 17:35:23]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2014-09-19 17:35:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/585563003/90001

[commit-bot: I haz the power, 2014-09-19 19:17:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-19 19:17:52]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/27913)

[qinmin, 2014-09-19 23:50:50]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2014-09-19 23:51:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/585563003/90001

[commit-bot: I haz the power, 2014-09-20 01:21:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-20 01:21:49]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/27980)

[qinmin, 2014-09-22 23:53:24]

Patchset #5 (id:110001) has been deleted

[qinmin, 2014-09-23 17:57:49]

Patchset #5 (id:130001) has been deleted

[qinmin, 2014-09-23 19:05:59]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2014-09-23 21:07:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-23 21:07:34]

Exceeded time limit waiting for builds to trigger.

[qinmin, 2014-09-23 21:07:56]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2014-09-23 21:08:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/585563003/150001

[commit-bot: I haz the power, 2014-09-23 22:20:20]

Committed patchset #5 (id:150001) as 182519