Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 585563002: [SVG] Restore the non-selection style after painting the selected run (Closed)

Created:
6 years, 3 months ago by fs
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, rwlbuis, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, pdr+svgwatchlist_chromium.org, rune+blink
Project:
blink
Visibility:
Public.

Description

[SVG] Restore the non-selection style after painting the selected run After having painted the selection-styled text run, the resources need to be re-acquired with the non-selection style. BUG=415632 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182311

Patch Set 1 #

Patch Set 2 : Tweak test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
A LayoutTests/svg/text/selection-partial-gradient.html View 1 1 chunk +22 lines, -0 lines 0 comments Download
A LayoutTests/svg/text/selection-partial-gradient-expected.html View 1 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
fs
This fixes a regression introduced by https://codereview.chromium.org/236203020
6 years, 3 months ago (2014-09-18 18:14:05 UTC) #2
fs
On 2014/09/18 18:14:05, fs wrote: > This fixes a regression introduced by https://codereview.chromium.org/236203020 Looks like ...
6 years, 3 months ago (2014-09-18 18:29:15 UTC) #3
pdr.
On 2014/09/18 18:29:15, fs wrote: > On 2014/09/18 18:14:05, fs wrote: > > This fixes ...
6 years, 3 months ago (2014-09-18 18:45:39 UTC) #4
fs
On 2014/09/18 18:45:39, pdr wrote: > On 2014/09/18 18:29:15, fs wrote: > > On 2014/09/18 ...
6 years, 3 months ago (2014-09-19 09:19:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/585563002/20001
6 years, 3 months ago (2014-09-19 09:20:38 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 09:33:53 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 182311

Powered by Google App Engine
This is Rietveld 408576698