Issue 58553003: Pass the AlternateNavInfoBarDelegate an AutocompleteMatch instead of a GURL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 58553003: Pass the AlternateNavInfoBarDelegate an AutocompleteMatch instead of a GURL. (Closed)

Created:
7 years, 1 month ago by Peter Kasting

Modified:
7 years, 1 month ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Pass the AlternateNavInfoBarDelegate an AutocompleteMatch instead of a GURL. This will be necessary for an upcoming change to make the infobar update the ShortcutsBackend when the user clicks the link. BUG=151044 TEST=none R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232901

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -20 lines)			Patch
M	chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.h	View	4 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.cc	View	3 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/omnibox/omnibox_edit_model.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/omnibox/omnibox_navigation_observer.h	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/omnibox/omnibox_navigation_observer.cc	View	3 chunks	+7 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

Peter Kasting

7 years, 1 month ago (2013-11-05 04:15:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r232901 (presubmit successful).