Simplify a little in SkRecords.h:

Simplify a little in SkRecords.h:

 - ACT_AS_PTR can just expose const methods to get at the pointers.
   (If the thing stored must stay const, we pass a const T.)
 - DrawPatch works fine with Record# macros, so use Record5.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/9b222a5ddd3b39ca191d8443bade6052cdcb713d

[mtklein, 2014-09-18 15:27:13]

The CQ bit was checked by mtklein@google.com

[mtklein, 2014-09-18 15:27:29]

mtklein@google.com changed reviewers:
+ fmalita@google.com

[commit-bot: I haz the power, 2014-09-18 15:28:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/585523003/1

[commit-bot: I haz the power, 2014-09-18 15:28:12]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from a valid reviewer till 2014-09-18 21:28 UTC

[mtklein, 2014-09-18 15:30:09]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-09-18 15:30:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/585523003/20001

[commit-bot: I haz the power, 2014-09-18 15:30:13]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from a valid reviewer till 2014-09-18 21:30 UTC

[mtklein, 2014-09-18 15:34:49]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-09-18 15:34:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/585523003/40001

[commit-bot: I haz the power, 2014-09-18 15:34:52]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from a valid reviewer till 2014-09-18 21:34 UTC

[tfarina, 2014-09-18 17:35:43]

the rest looks fine.

https://codereview.chromium.org/585523003/diff/40001/src/core/SkRecords.h
File src/core/SkRecords.h (left):

https://codereview.chromium.org/585523003/diff/40001/src/core/SkRecords.h#old...
src/core/SkRecords.h:122: operator T*() { return ptr; }             \
why not keep non-const and const versions?

it seems more const-correctness, than:

foo* ptr() const { return ptr; }

In chromium we have been trying to have:

foo* ptr() { return ptr; }
const foo* ptr() const { return ptr; }

[mtklein, 2014-09-18 17:52:39]

https://codereview.chromium.org/585523003/diff/40001/src/core/SkRecords.h
File src/core/SkRecords.h (left):

https://codereview.chromium.org/585523003/diff/40001/src/core/SkRecords.h#old...
src/core/SkRecords.h:122: operator T*() { return ptr; }             \
Mostly this is because it is inconvenient to use the existing ACT_AS_PTR with
the handful of types in Skia which are immutable but not typically passed by
const*, like SkTypeface and here in particular SkXfermode.

If we left it as const* ptr() const, there's no way for us to get back to the
non-const SkXfermode* we'll need to be able to play the SkRecord back into an
SkCanvas.  SkCanvas::drawPatch takes an SkXfermode*, so we need to preserve its
non-constness.

Generally, if we really want to prevent getting back a non-const pointer, it's
even better to work with it as RefBox<const T> instead of RefBox<T>.  This is
how the C++ standard libary works, for example: std::unique_ptr and
std::shared_ptr both have T* get() const; methods, same sort of thing as we're
doing here.

[reed1, 2014-09-18 18:15:41]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2014-09-18 18:15:41]

lgtm

[commit-bot: I haz the power, 2014-09-18 18:16:38]

Committed patchset #3 (id:40001) as 9b222a5ddd3b39ca191d8443bade6052cdcb713d