Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Issue 585473003: Use a more specific type, mach_exception_code_t, when possible (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Use a more specific type, mach_exception_code_t, when possible. mach_exception_data_type_t is more generic and is used for any element of a codes[] array. For individual elements, the typedefs mach_exception_code_t and mach_exception_subcode_t are available. Using mach_exception_code_t when possible gives slightly more descriptive code. No functional change. TEST=util_test ExcServerVariants.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/021c93c2e06882958d1b3feb2c8fc1bd6ffda8f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M tools/catch_exception_tool.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/mach/exc_server_variants.h View 1 chunk +2 lines, -2 lines 0 comments Download
M util/mach/exc_server_variants.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M util/mach/exc_server_variants_test.cc View 5 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years, 3 months ago (2014-09-18 14:16:06 UTC) #2
Robert Sesek
LGTM
6 years, 3 months ago (2014-09-18 14:50:26 UTC) #3
Mark Mentovai
6 years, 3 months ago (2014-09-18 15:56:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 021c93c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698