Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 585433002: Turn keyed loads with string-based (non-convertible to array-index) key into named loads (Closed)

Created:
6 years, 3 months ago by Toon Verwaest
Modified:
6 years, 3 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Turn keyed loads with string-based (non-convertible to array-index) key into named loads BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24032

Patch Set 1 #

Patch Set 2 : Add test #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -12 lines) Patch
M src/hydrogen.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/hydrogen.cc View 1 2 3 4 chunks +25 lines, -8 lines 0 comments Download
A test/mjsunit/keyed-named-access.js View 1 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Toon Verwaest
PTAL
6 years, 3 months ago (2014-09-18 09:57:53 UTC) #2
Igor Sheludko
https://codereview.chromium.org/585433002/diff/20001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/585433002/diff/20001/src/hydrogen.cc#newcode7136 src/hydrogen.cc:7136: BuildNamedAccess(access_type, expr->id(), expr->id(), expr, obj, As you noticed you ...
6 years, 3 months ago (2014-09-18 11:25:37 UTC) #3
Toon Verwaest
Addressed comments
6 years, 3 months ago (2014-09-18 11:41:55 UTC) #4
Igor Sheludko
lgtm
6 years, 3 months ago (2014-09-18 11:54:19 UTC) #5
Toon Verwaest
6 years, 3 months ago (2014-09-18 12:00:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 24032 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698