Issue 585433002: Turn keyed loads with string-based (non-convertible to array-index) key into named loads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 585433002: Turn keyed loads with string-based (non-convertible to array-index) key into named loads (Closed)

Created:
6 years, 3 months ago by Toon Verwaest

Modified:
6 years, 3 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Turn keyed loads with string-based (non-convertible to array-index) key into named loads BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24032

Patch Set 4 : #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -12 lines)			Patch
M	src/hydrogen.h	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/hydrogen.cc	View	1 2 3	4 chunks	+25 lines, -8 lines	0 comments	Download
A	test/mjsunit/keyed-named-access.js	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Igor Sheludko

https://codereview.chromium.org/585433002/diff/20001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/585433002/diff/20001/src/hydrogen.cc#newcode7136 src/hydrogen.cc:7136: BuildNamedAccess(access_type, expr->id(), expr->id(), expr, obj, As you noticed you ...

6 years, 3 months ago (2014-09-18 11:25:37 UTC) #3

Toon Verwaest

6 years, 3 months ago (2014-09-18 12:00:11 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as 24032 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 585433002: Turn keyed loads with string-based (non-convertible to array-index) key into named loads (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add test #

Patch Set 3 : #

Patch Set 4 : #

Messages