Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 58543003: gyp: Put back common dependency on api, because the hard_dependency property isn't transitive. (Closed)

Created:
7 years, 1 month ago by Yoyo Zhou
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

gyp: Put back common dependency on api, because the hard_dependency property isn't transitive. BUG=314916, 162530 R=benwells@chromium.org, kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233066

Patch Set 1 #

Patch Set 2 : , #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/chrome_common.gypi View 1 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
Yoyo Zhou
7 years, 1 month ago (2013-11-05 01:04:38 UTC) #1
not at google - send to devlin
lgtm https://codereview.chromium.org/58543003/diff/20001/chrome/chrome_common.gypi File chrome/chrome_common.gypi (right): https://codereview.chromium.org/58543003/diff/20001/chrome/chrome_common.gypi#newcode416 chrome/chrome_common.gypi:416: '../device/usb/usb.gyp:device_usb', seems like it should go in here, ...
7 years, 1 month ago (2013-11-05 01:07:24 UTC) #2
Yoyo Zhou
https://codereview.chromium.org/58543003/diff/20001/chrome/chrome_common.gypi File chrome/chrome_common.gypi (right): https://codereview.chromium.org/58543003/diff/20001/chrome/chrome_common.gypi#newcode416 chrome/chrome_common.gypi:416: '../device/usb/usb.gyp:device_usb', On 2013/11/05 01:07:25, kalman wrote: > seems like ...
7 years, 1 month ago (2013-11-05 01:10:55 UTC) #3
Yoyo Zhou
Per kareng, waiting until after the branch tonight to land this.
7 years, 1 month ago (2013-11-05 01:12:56 UTC) #4
benwells
lgtm2
7 years, 1 month ago (2013-11-05 03:38:05 UTC) #5
Yoyo Zhou
7 years, 1 month ago (2013-11-05 20:15:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r233066 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698