Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: Source/core/rendering/RenderLayerModelObject.h

Issue 58543002: Use a boolean hasCompositedLayerMapping() accessor instead of the pointer (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update comment for hasCompositedLayerMapping Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007, 2009 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007, 2009 Apple Inc. All rights reserved.
5 * Copyright (C) 2010, 2012 Google Inc. All rights reserved. 5 * Copyright (C) 2010, 2012 Google Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
11 * 11 *
12 * This library is distributed in the hope that it will be useful, 12 * This library is distributed in the hope that it will be useful,
13 * but WITHOUT ANY WARRANTY; without even the implied warranty of 13 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 14 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
15 * Library General Public License for more details. 15 * Library General Public License for more details.
16 * 16 *
17 * You should have received a copy of the GNU Library General Public License 17 * You should have received a copy of the GNU Library General Public License
18 * along with this library; see the file COPYING.LIB. If not, write to 18 * along with this library; see the file COPYING.LIB. If not, write to
19 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 19 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
20 * Boston, MA 02110-1301, USA. 20 * Boston, MA 02110-1301, USA.
21 */ 21 */
22 22
23 #ifndef RenderLayerModelObject_h 23 #ifndef RenderLayerModelObject_h
24 #define RenderLayerModelObject_h 24 #define RenderLayerModelObject_h
25 25
26 #include "core/rendering/CompositedLayerMappingPtr.h"
26 #include "core/rendering/RenderObject.h" 27 #include "core/rendering/RenderObject.h"
27 28
28 namespace WebCore { 29 namespace WebCore {
29 30
30 class RenderLayer; 31 class RenderLayer;
31 class CompositedLayerMapping; 32 class CompositedLayerMapping;
32 class ScrollableArea; 33 class ScrollableArea;
33 34
34 class RenderLayerModelObject : public RenderObject { 35 class RenderLayerModelObject : public RenderObject {
35 public: 36 public:
(...skipping 13 matching lines...) Expand all
49 50
50 virtual bool requiresLayer() const = 0; 51 virtual bool requiresLayer() const = 0;
51 52
52 // Returns true if the background is painted opaque in the given rect. 53 // Returns true if the background is painted opaque in the given rect.
53 // The query rect is given in local coordinate system. 54 // The query rect is given in local coordinate system.
54 virtual bool backgroundIsKnownToBeOpaqueInRect(const LayoutRect&) const { re turn false; } 55 virtual bool backgroundIsKnownToBeOpaqueInRect(const LayoutRect&) const { re turn false; }
55 56
56 // This is null for anonymous renderers. 57 // This is null for anonymous renderers.
57 ContainerNode* node() const { return toContainerNode(RenderObject::node()); } 58 ContainerNode* node() const { return toContainerNode(RenderObject::node()); }
58 59
59 CompositedLayerMapping* compositedLayerMapping() const; 60 CompositedLayerMappingPtr compositedLayerMapping() const;
61 bool hasCompositedLayerMapping() const;
60 62
61 protected: 63 protected:
62 void createLayer(); 64 void createLayer();
63 65
64 virtual void willBeDestroyed() OVERRIDE; 66 virtual void willBeDestroyed() OVERRIDE;
65 67
66 virtual void addLayerHitTestRects(LayerHitTestRects&, const RenderLayer*, co nst LayoutPoint&, const LayoutRect&) const OVERRIDE; 68 virtual void addLayerHitTestRects(LayerHitTestRects&, const RenderLayer*, co nst LayoutPoint&, const LayoutRect&) const OVERRIDE;
67 69
68 private: 70 private:
69 virtual bool isLayerModelObject() const OVERRIDE FINAL { return true; } 71 virtual bool isLayerModelObject() const OVERRIDE FINAL { return true; }
70 72
71 OwnPtr<RenderLayer> m_layer; 73 OwnPtr<RenderLayer> m_layer;
72 74
73 // Used to store state between styleWillChange and styleDidChange 75 // Used to store state between styleWillChange and styleDidChange
74 static bool s_wasFloating; 76 static bool s_wasFloating;
75 static bool s_hadLayer; 77 static bool s_hadLayer;
76 static bool s_hadTransform; 78 static bool s_hadTransform;
77 static bool s_layerWasSelfPainting; 79 static bool s_layerWasSelfPainting;
78 }; 80 };
79 81
80 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderLayerModelObject, isLayerModelObject()); 82 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderLayerModelObject, isLayerModelObject());
81 83
82 } // namespace WebCore 84 } // namespace WebCore
83 85
84 #endif // RenderLayerModelObject_h 86 #endif // RenderLayerModelObject_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderLayerCompositor.cpp ('k') | Source/core/rendering/RenderLayerModelObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698