Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Side by Side Diff: Source/core/frame/FrameView.cpp

Issue 58543002: Use a boolean hasCompositedLayerMapping() accessor instead of the pointer (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update comment for hasCompositedLayerMapping Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/inspector/InspectorLayerTreeAgent.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 2051 matching lines...) Expand 10 before | Expand all | Expand 10 after
2062 } 2062 }
2063 2063
2064 bool FrameView::isTransparent() const 2064 bool FrameView::isTransparent() const
2065 { 2065 {
2066 return m_isTransparent; 2066 return m_isTransparent;
2067 } 2067 }
2068 2068
2069 void FrameView::setTransparent(bool isTransparent) 2069 void FrameView::setTransparent(bool isTransparent)
2070 { 2070 {
2071 m_isTransparent = isTransparent; 2071 m_isTransparent = isTransparent;
2072 if (renderView() && renderView()->layer()->compositedLayerMapping()) 2072 if (renderView() && renderView()->layer()->hasCompositedLayerMapping())
2073 renderView()->layer()->compositedLayerMapping()->updateContentsOpaque(); 2073 renderView()->layer()->compositedLayerMapping()->updateContentsOpaque();
2074 } 2074 }
2075 2075
2076 bool FrameView::hasOpaqueBackground() const 2076 bool FrameView::hasOpaqueBackground() const
2077 { 2077 {
2078 return !m_isTransparent && !m_baseBackgroundColor.hasAlpha(); 2078 return !m_isTransparent && !m_baseBackgroundColor.hasAlpha();
2079 } 2079 }
2080 2080
2081 Color FrameView::baseBackgroundColor() const 2081 Color FrameView::baseBackgroundColor() const
2082 { 2082 {
2083 return m_baseBackgroundColor; 2083 return m_baseBackgroundColor;
2084 } 2084 }
2085 2085
2086 void FrameView::setBaseBackgroundColor(const Color& backgroundColor) 2086 void FrameView::setBaseBackgroundColor(const Color& backgroundColor)
2087 { 2087 {
2088 if (!backgroundColor.isValid()) 2088 if (!backgroundColor.isValid())
2089 m_baseBackgroundColor = Color::white; 2089 m_baseBackgroundColor = Color::white;
2090 else 2090 else
2091 m_baseBackgroundColor = backgroundColor; 2091 m_baseBackgroundColor = backgroundColor;
2092 2092
2093 if (CompositedLayerMapping* compositedLayerMapping = renderView() ? renderVi ew()->layer()->compositedLayerMapping() : 0) { 2093 if (renderView() && renderView()->layer()->hasCompositedLayerMapping()) {
2094 CompositedLayerMappingPtr compositedLayerMapping = renderView()->layer() ->compositedLayerMapping();
2094 compositedLayerMapping->updateContentsOpaque(); 2095 compositedLayerMapping->updateContentsOpaque();
2095 if (compositedLayerMapping->mainGraphicsLayer()) 2096 if (compositedLayerMapping->mainGraphicsLayer())
2096 compositedLayerMapping->mainGraphicsLayer()->setNeedsDisplay(); 2097 compositedLayerMapping->mainGraphicsLayer()->setNeedsDisplay();
2097 } 2098 }
2098 recalculateScrollbarOverlayStyle(); 2099 recalculateScrollbarOverlayStyle();
2099 } 2100 }
2100 2101
2101 void FrameView::updateBackgroundRecursively(const Color& backgroundColor, bool t ransparent) 2102 void FrameView::updateBackgroundRecursively(const Color& backgroundColor, bool t ransparent)
2102 { 2103 {
2103 for (Frame* frame = m_frame.get(); frame; frame = frame->tree().traverseNext (m_frame.get())) { 2104 for (Frame* frame = m_frame.get(); frame; frame = frame->tree().traverseNext (m_frame.get())) {
(...skipping 1396 matching lines...) Expand 10 before | Expand all | Expand 10 after
3500 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation) 3501 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation)
3501 { 3502 {
3502 ScrollableArea::willRemoveScrollbar(scrollbar, orientation); 3503 ScrollableArea::willRemoveScrollbar(scrollbar, orientation);
3503 if (AXObjectCache* cache = axObjectCache()) { 3504 if (AXObjectCache* cache = axObjectCache()) {
3504 cache->remove(scrollbar); 3505 cache->remove(scrollbar);
3505 cache->handleScrollbarUpdate(this); 3506 cache->handleScrollbarUpdate(this);
3506 } 3507 }
3507 } 3508 }
3508 3509
3509 } // namespace WebCore 3510 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/inspector/InspectorLayerTreeAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698