Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 585423002: Merge RecordComment invocations into DeoptimizeIf calls. (Closed)

Created:
6 years, 3 months ago by Sven Panne
Modified:
6 years, 3 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Merge RecordComment invocations into DeoptimizeIf calls. This way the deoptimization reasons are actually threaded through to the jump table. Tiny cleanup of related MIPS/MIPS64 code on the way. R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24111

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -90 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 4 chunks +8 lines, -16 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 3 chunks +11 lines, -12 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 3 chunks +11 lines, -12 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 4 chunks +8 lines, -16 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 6 chunks +10 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Sven Panne
6 years, 3 months ago (2014-09-22 09:28:28 UTC) #2
Jarin
lgtm
6 years, 3 months ago (2014-09-22 09:32:15 UTC) #3
Sven Panne
6 years, 3 months ago (2014-09-22 09:50:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24111 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698