Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 585393002: Use changed_button_flags() when converting MouseEvent to blink::WebMouseEvent. (Closed)

Created:
6 years, 3 months ago by joleksy
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use changed_button_flags() when converting MouseEvent to blink::WebMouseEvent. Event::flags() contains all the buttons that are being held down during event, while MouseEvent::changed_button_flags() contains the buttons that are actually pressed/released during the press/release event (and this is what we really are interested in). This is a follow up to https://codereview.chromium.org/302593002/ which caused problems during integration, and it seems to me it got just closed, so I am opening a new one. Committed: https://crrev.com/a1d1985ccaae302c911676f41c0b062ee7c32371 Cr-Commit-Position: refs/heads/master@{#296691}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M content/browser/renderer_host/web_input_event_aura.cc View 1 chunk +12 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
joleksy
@reviewer: does it look ok to you?
6 years, 3 months ago (2014-09-22 07:42:12 UTC) #2
Ben Goodger (Google)
lgtm
6 years, 3 months ago (2014-09-24 17:25:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585393002/1
6 years, 2 months ago (2014-09-25 06:26:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8d0e706bfdeb1f0a382322b536da9bf9ed769146
6 years, 2 months ago (2014-09-25 11:23:06 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 11:23:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1d1985ccaae302c911676f41c0b062ee7c32371
Cr-Commit-Position: refs/heads/master@{#296691}

Powered by Google App Engine
This is Rietveld 408576698