src/v8natives.js - Issue 585373003: Convert `obj` ToObject in Object.keys()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/v8natives.js

Issue 585373003: Convert `obj` ToObject in Object.keys() (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Skip es5 test262 tests which assert that Object.keys() throws on primitives Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/v8natives.js

diff --git a/src/v8natives.js b/src/v8natives.js

index 782b953ea9763edf0dadbc32511d32a6deef0463..bc6a375d7513050c004de62ba3fd9f91a7fd00ba 100644

--- a/src/v8natives.js

+++ b/src/v8natives.js

@@ -325,9 +325,7 @@ function ObjectLookupSetter(name) {

function ObjectKeys(obj) {

- if (!IS_SPEC_OBJECT(obj)) {

- throw MakeTypeError("called_on_non_object", ["Object.keys"]);

- }

+ obj = ToObject(obj);

if (%IsJSProxy(obj)) {

var handler = %GetHandler(obj);

var names = CallTrap0(handler, "keys", DerivedKeysTrap);