LayoutTests/fast/dom/HTMLDialogElement/non-anchored-dialog-positioning.html - Issue 58533003: Move fast/js/resources files to resources.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/HTMLDialogElement/non-anchored-dialog-positioning.html

Issue 58533003: Move fast/js/resources files to resources. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/fast/dom/HTMLDialogElement/multiple-centered-dialogs.html ('k') | LayoutTests/fast/dom/HTMLDialogElement/non-modal-dialog-does-not-block-mouse-events.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <style>	4 <style>

5 /* Remove body margin and dialog styles to allow comparing dialog's position wit h that of plain span elements. */	5 /* Remove body margin and dialog styles to allow comparing dialog's position wit h that of plain span elements. */

6 body {	6 body {

7 margin: 0;	7 margin: 0;

8 }	8 }

9	9

10 dialog {	10 dialog {

11 border: 0;	11 border: 0;

12 padding: 0;	12 padding: 0;

13 height: auto;	13 height: auto;

14 width: auto;	14 width: auto;

15 }	15 }

16	16

17 .filler {	17 .filler {

18 height: 20000px;	18 height: 20000px;

19 }	19 }

20	20

21 </style>	21 </style>

22 <script src="../../js/resources/js-test-pre.js"></script>	22 <script src="../../../resources/js-test.js"></script>

23 <script>	23 <script>

24 function checkTopOfViewport(dialog) {	24 function checkTopOfViewport(dialog) {

25 shouldBe('dialog.getBoundingClientRect().top', '0');	25 shouldBe('dialog.getBoundingClientRect().top', '0');

26 }	26 }

27	27

28 function checkCentered(dialog) {	28 function checkCentered(dialog) {

29 expectedTop = (window.innerHeight - dialog.offsetHeight) / 2;	29 expectedTop = (window.innerHeight - dialog.offsetHeight) / 2;

30 shouldBe('dialog.getBoundingClientRect().top', 'expectedTop');	30 shouldBe('dialog.getBoundingClientRect().top', 'expectedTop');

31 }	31 }

32	32

(...skipping 173 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
206 plainSpan.parentNode.removeChild(plainSpan);	206 plainSpan.parentNode.removeChild(plainSpan);

207 dialog.style.position = 'relative';	207 dialog.style.position = 'relative';

208 dialog.style.top = '50px';	208 dialog.style.top = '50px';

209 // Just test non-modal since modal is covered by other tests (for modal, relativ e computes to absolute)	209 // Just test non-modal since modal is covered by other tests (for modal, relativ e computes to absolute)

210 dialog.show();	210 dialog.show();

211 shouldBe('dialog.getBoundingClientRect().top', 'expectedTop');	211 shouldBe('dialog.getBoundingClientRect().top', 'expectedTop');

212 dialog.close();	212 dialog.close();

213 </script>	213 </script>

214 </body>	214 </body>

215 </html>	215 </html>

OLD	NEW