sdk/lib/_internal/compiler/implementation/constant_system_dart.dart - Issue 585173002: dart2js: Support new const operations on strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/constant_system_dart.dart

Issue 585173002: dart2js: Support new const operations on strings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Add null check. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/compile_time_constants.dart ('k') | sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart » ('j') | sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/constant_system_dart.dart

diff --git a/sdk/lib/_internal/compiler/implementation/constant_system_dart.dart b/sdk/lib/_internal/compiler/implementation/constant_system_dart.dart

index 19e084ed4a58128446c7fbe5126535c2f65f6da3..2ee5413e38a36feb3d6077805f45d367e5f5b0c1 100644

--- a/sdk/lib/_internal/compiler/implementation/constant_system_dart.dart

+++ b/sdk/lib/_internal/compiler/implementation/constant_system_dart.dart

@@ -231,6 +231,12 @@ class AddOperation implements BinaryOperation {

NumConstant rightNum = right;

double result = leftNum.value + rightNum.value;

return DART_CONSTANT_SYSTEM.createDouble(result);

+ } else if (left.isString && right.isString) {

+ StringConstant leftString = left;

+ StringConstant rightString = right;

+ DartString result =

+ new DartString.concat(leftString.value, rightString.value);

+ return DART_CONSTANT_SYSTEM.createString(result);

} else {

return null;

}