Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 585153002: Compiling file_manager, part 1: change all <include/> to <include> (Closed)

Created:
6 years, 3 months ago by Vitaly Pavlenko
Modified:
6 years, 3 months ago
Reviewers:
Dan Beam, fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@true_master
Project:
chromium
Visibility:
Public.

Description

Compiling file_manager, part 1: change all <include/> to <include> BUG=393873 R=dbeam@chromium.org Committed: https://crrev.com/e1510b19ff70ca655dfe69ce20a2e22ceb2ce7af Cr-Commit-Position: refs/heads/master@{#296113}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -128 lines) Patch
M ui/file_manager/file_manager/audio_player/js/audio_player_scripts.js View 2 chunks +14 lines, -14 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/main_scripts.js View 1 chunk +77 lines, -77 lines 0 comments Download
M ui/file_manager/gallery/js/gallery_scripts.js View 2 chunks +15 lines, -15 lines 0 comments Download
M ui/file_manager/video_player/js/video_player_scripts.js View 1 chunk +22 lines, -22 lines 0 comments Download

Messages

Total messages: 26 (11 generated)
Vitaly Pavlenko
6 years, 3 months ago (2014-09-19 23:25:00 UTC) #1
Dan Beam
lgtm
6 years, 3 months ago (2014-09-19 23:27:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585153002/1
6 years, 3 months ago (2014-09-19 23:28:34 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/12342)
6 years, 3 months ago (2014-09-19 23:50:16 UTC) #6
Vitaly Pavlenko
On 2014/09/19 23:50:16, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 3 months ago (2014-09-20 00:44:20 UTC) #8
mtomasz
On 2014/09/20 00:44:20, Vitaly Pavlenko wrote: > On 2014/09/19 23:50:16, I haz the power (commit-bot) ...
6 years, 3 months ago (2014-09-20 01:44:29 UTC) #9
fukino
lgtm. Thanks!
6 years, 3 months ago (2014-09-21 20:29:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585153002/1
6 years, 3 months ago (2014-09-22 16:15:19 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/12590)
6 years, 3 months ago (2014-09-22 16:27:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585153002/20001
6 years, 3 months ago (2014-09-22 17:27:20 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585153002/40001
6 years, 3 months ago (2014-09-22 17:31:17 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/12616)
6 years, 3 months ago (2014-09-22 17:43:42 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585153002/40001
6 years, 3 months ago (2014-09-23 00:44:55 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001) as b0e1c86b7807ee195ee35609f8e9f19eabdf2c4a
6 years, 3 months ago (2014-09-23 00:51:39 UTC) #25
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 00:52:25 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e1510b19ff70ca655dfe69ce20a2e22ceb2ce7af
Cr-Commit-Position: refs/heads/master@{#296113}

Powered by Google App Engine
This is Rietveld 408576698