Disable remote TTS services when offline.

Disable remote TTS services when offline.

BUG=314801
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233432

[not at google - send to devlin, 2013-11-04 23:30:43]

lgtm

https://codereview.chromium.org/58513003/diff/1/chrome/browser/speech/extensi...
File chrome/browser/speech/extension_api/tts_extension_apitest.cc (right):

https://codereview.chromium.org/58513003/diff/1/chrome/browser/speech/extensi...
chrome/browser/speech/extension_api/tts_extension_apitest.cc:403:
FakeNetworkOnlineStateForTest fake_online_state(true);
how... does this get installed? but sure.

[dmazzoni, 2013-11-04 23:38:14]

https://codereview.chromium.org/58513003/diff/1/chrome/browser/speech/extensi...
File chrome/browser/speech/extension_api/tts_extension_apitest.cc (right):

https://codereview.chromium.org/58513003/diff/1/chrome/browser/speech/extensi...
chrome/browser/speech/extension_api/tts_extension_apitest.cc:403:
FakeNetworkOnlineStateForTest fake_online_state(true);
On 2013/11/04 23:30:43, kalman wrote:
> how... does this get installed? but sure.

It's a little odd, but a NetworkChangeNotifier registers itself as the global
network change notifier upon construction, so to create your own in a test you
just have to create a DisableForTest first...

[not at google - send to devlin, 2013-11-04 23:40:45]

https://codereview.chromium.org/58513003/diff/1/chrome/browser/speech/extensi...
File chrome/browser/speech/extension_api/tts_extension_apitest.cc (right):

https://codereview.chromium.org/58513003/diff/1/chrome/browser/speech/extensi...
chrome/browser/speech/extension_api/tts_extension_apitest.cc:403:
FakeNetworkOnlineStateForTest fake_online_state(true);
On 2013/11/04 23:38:15, Dominic Mazzoni wrote:
> On 2013/11/04 23:30:43, kalman wrote:
> > how... does this get installed? but sure.
> 
> It's a little odd, but a NetworkChangeNotifier registers itself as the global
> network change notifier upon construction, so to create your own in a test you
> just have to create a DisableForTest first...

You could make the DisableForTest a member of FakeNetworkOnlineStateForTest, but
I can't decide whether that's any better.

[David Tseng, 2013-11-04 23:55:17]

https://codereview.chromium.org/58513003/diff/1/chrome/browser/speech/extensi...
File chrome/browser/speech/extension_api/tts_engine_extension_api.cc (right):

https://codereview.chromium.org/58513003/diff/1/chrome/browser/speech/extensi...
chrome/browser/speech/extension_api/tts_engine_extension_api.cc:70:
net::NetworkChangeNotifier::CONNECTION_NONE);
What happens if you go offline after retrieving voices?
Shouldn't we fallback to a non-remote voice in speak() if that's the case?

[dmazzoni, 2013-11-05 18:11:14]

https://codereview.chromium.org/58513003/diff/1/chrome/browser/speech/extensi...
File chrome/browser/speech/extension_api/tts_engine_extension_api.cc (right):

https://codereview.chromium.org/58513003/diff/1/chrome/browser/speech/extensi...
chrome/browser/speech/extension_api/tts_engine_extension_api.cc:70:
net::NetworkChangeNotifier::CONNECTION_NONE);
On 2013/11/04 23:55:17, David Tseng wrote:
> What happens if you go offline after retrieving voices?
> Shouldn't we fallback to a non-remote voice in speak() if that's the case?

Yes, that will happen automatically, because when it reaches the front of the
queue, TtsController::SpeakNow calls GetVoices, which calls this function,
GetExtensionVoices, to build up the list of voices actually available at that
moment. So if it's offline it won't send the speak command to a remote voice.

[commit-bot: I haz the power, 2013-11-06 17:48:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/58513003/1

[commit-bot: I haz the power, 2013-11-07 00:20:21]

Change committed as 233432