Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 585093002: Mojo: Make MessagePipe::ConvertLocalToProxy() create the ChannelEndpoint. (Closed)

Created:
6 years, 3 months ago by viettrungluu
Modified:
6 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_attachmpe
Project:
chromium
Visibility:
Public.

Description

Mojo: Make MessagePipe::ConvertLocalToProxy() create the ChannelEndpoint. This will be needed to move the "paused message queue" into the ChannelEndpoint, since transferring messages from the LocalMessagePipeEndpoint needs to happen "atomically" with its conversion to a ProxyMessagePipeEndpoint. (Before the MessagePipe lock is released, the ProxyMessagePipeEndpoint needs to have a place to queue messages, and any already-queued messages must be at the front of that queue.) R=darin@chromium.org Committed: https://crrev.com/0d2f449cd9c3f6ac459a712e182d350c0ff1b210 Cr-Commit-Position: refs/heads/master@{#295822}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M mojo/system/message_pipe.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/message_pipe.cc View 3 chunks +4 lines, -1 line 0 comments Download
M mojo/system/message_pipe_dispatcher.cc View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
viettrungluu
6 years, 3 months ago (2014-09-19 21:12:46 UTC) #1
darin (slow to review)
lgtm
6 years, 3 months ago (2014-09-19 21:15:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585093002/20001
6 years, 3 months ago (2014-09-19 22:01:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585093002/20001
6 years, 3 months ago (2014-09-19 22:02:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/15795)
6 years, 3 months ago (2014-09-19 23:44:39 UTC) #7
viettrungluu
Committed patchset #2 (id:20001) manually as 0d2f449 (presubmit successful).
6 years, 3 months ago (2014-09-20 00:07:14 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 00:07:16 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0d2f449cd9c3f6ac459a712e182d350c0ff1b210
Cr-Commit-Position: refs/heads/master@{#295822}

Powered by Google App Engine
This is Rietveld 408576698