Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 585063002: Made double-tap zoom work in pinch virtual viewport mode (Chromium-side). (Closed)

Created:
6 years, 3 months ago by bokan
Modified:
6 years, 2 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Made double-tap zoom work in pinch virtual viewport mode (Chromium-side). On the Blink side: The clamping method used by computeScaleAndScrollForBlockRect now uses a new method PinchViewport::clampDocumentOffsetAtScale to clamp the requested viewport offset taking into account the inner and outer viewports. Also added an overload of applyViewportDeltas, called in virtual viewport mode only, that applies the inner and outer deltas along page scale in one shot. This makes the viewport layers a special case again in that their scroll offsets are set through this call, rather than the standard 'did_scroll' callback of most layers. This is needed since the scroll offsets may be invalid until the page scale is applied so this is handled in one method to prevent unintended clamping. On the Compositor side: Calls the appropriate applyViewportDeltas based on which pinch mode we're running in. The page scale animation now prefers to scroll the inner viewport first, scrolling the outer only when the inner has reached its scroll extent. Blink-side: https://codereview.chromium.org/584833003 BUG=364106 Committed: https://crrev.com/59379b09a4cbc478ce8e72db7bc658d9a8421ef5 Cr-Commit-Position: refs/heads/master@{#297167}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Build fix #

Patch Set 5 : Build fix #2 #

Patch Set 6 : Another build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -8 lines) Patch
M android_webview/browser/hardware_renderer.h View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M cc/test/fake_layer_tree_host_client.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M cc/test/layer_tree_test.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 2 2 chunks +15 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_client.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 2 chunks +10 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_no_message_loop.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/examples/compositor_app/compositor_host.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/examples/compositor_app/compositor_host.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/weblayertreeview_impl.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/weblayertreeview_impl.cc View 1 2 3 4 1 chunk +12 lines, -0 lines 0 comments Download
M ui/compositor/compositor.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (8 generated)
bokan
Alexandre, working on tests now but PTAL at this and the Blink-side patch.
6 years, 3 months ago (2014-09-19 20:00:59 UTC) #2
bokan
Hey Alex, PTAL at this side too. Thanks.
6 years, 3 months ago (2014-09-23 00:49:57 UTC) #3
aelias_OOO_until_Jul13
lgtm
6 years, 3 months ago (2014-09-23 01:07:42 UTC) #4
bokan
+jamesr@ for mojo/ +avi@ for content/renderer content/tests and ui/compositor
6 years, 3 months ago (2014-09-23 12:44:20 UTC) #6
Avi (use Gerrit)
The content side is just plumbing that LGTM.
6 years, 3 months ago (2014-09-23 14:09:55 UTC) #7
jamesr
lgtm
6 years, 3 months ago (2014-09-23 23:32:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585063002/40001
6 years, 3 months ago (2014-09-24 17:32:33 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/18588)
6 years, 3 months ago (2014-09-24 17:47:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585063002/60001
6 years, 3 months ago (2014-09-24 18:17:36 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/18470) android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/12038) linux_chromium_gn_rel ...
6 years, 3 months ago (2014-09-24 18:36:27 UTC) #16
bokan
+mkosiba@ for build fix in android_webview
6 years, 3 months ago (2014-09-24 19:20:53 UTC) #18
mkosiba (inactive)
android_webview/ LGTM
6 years, 2 months ago (2014-09-29 10:41:27 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585063002/100001
6 years, 2 months ago (2014-09-29 12:57:14 UTC) #21
commit-bot: I haz the power
Committed patchset #6 (id:100001) as f45f6fd2d77602bdceac54f7535571095d77e770
6 years, 2 months ago (2014-09-29 13:47:29 UTC) #22
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 13:48:10 UTC) #23
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/59379b09a4cbc478ce8e72db7bc658d9a8421ef5
Cr-Commit-Position: refs/heads/master@{#297167}

Powered by Google App Engine
This is Rietveld 408576698