|
Made double-tap zoom work in pinch virtual viewport mode (Chromium-side).
On the Blink side:
The clamping method used by computeScaleAndScrollForBlockRect now
uses a new method PinchViewport::clampDocumentOffsetAtScale to clamp
the requested viewport offset taking into account the inner and outer
viewports.
Also added an overload of applyViewportDeltas, called in virtual
viewport mode only, that applies the inner and outer deltas along
page scale in one shot. This makes the viewport layers a special case
again in that their scroll offsets are set through this call, rather
than the standard 'did_scroll' callback of most layers. This is needed
since the scroll offsets may be invalid until the page scale is
applied so this is handled in one method to prevent unintended
clamping.
On the Compositor side:
Calls the appropriate applyViewportDeltas based on which pinch mode
we're running in. The page scale animation now prefers to scroll the
inner viewport first, scrolling the outer only when the inner has
reached its scroll extent.
Blink-side: https://codereview.chromium.org/584833003
BUG= 364106
Committed: https://crrev.com/59379b09a4cbc478ce8e72db7bc658d9a8421ef5
Cr-Commit-Position: refs/heads/master@{#297167}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+119 lines, -8 lines) |
Patch |
 |
M |
android_webview/browser/hardware_renderer.h
|
View
|
1
2
3
4
5
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
cc/test/fake_layer_tree_host_client.h
|
View
|
1
2
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
cc/test/layer_tree_test.h
|
View
|
1
2
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
cc/test/layer_tree_test.cc
|
View
|
1
2
3
|
1 chunk |
+9 lines, -0 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host.cc
|
View
|
1
2
|
2 chunks |
+15 lines, -7 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host_client.h
|
View
|
1
2
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host_impl.h
|
View
|
1
2
3
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host_impl.cc
|
View
|
1
2
3
|
2 chunks |
+10 lines, -1 line |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host_unittest_no_message_loop.cc
|
View
|
1
2
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/compositor_impl_android.h
|
View
|
1
2
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/renderer/gpu/render_widget_compositor.h
|
View
|
1
2
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/renderer/gpu/render_widget_compositor.cc
|
View
|
1
2
|
1 chunk |
+12 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/test/web_layer_tree_view_impl_for_testing.h
|
View
|
1
2
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/test/web_layer_tree_view_impl_for_testing.cc
|
View
|
1
2
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
 |
M |
mojo/examples/compositor_app/compositor_host.h
|
View
|
1
2
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
mojo/examples/compositor_app/compositor_host.cc
|
View
|
1
2
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
mojo/services/html_viewer/weblayertreeview_impl.h
|
View
|
1
2
3
4
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
mojo/services/html_viewer/weblayertreeview_impl.cc
|
View
|
1
2
3
4
|
1 chunk |
+12 lines, -0 lines |
0 comments
|
Download
|
 |
M |
ui/compositor/compositor.h
|
View
|
1
2
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
Total messages: 23 (8 generated)
|