Issue 585053003: web_dev_style: enhance <include> presubmit to account for

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 585053003: web_dev_style: enhance <include> presubmit to account for (Closed)

Created:
6 years, 3 months ago by Dan Beam

Modified:
6 years, 3 months ago

Reviewers:
Tyler Breisacher (Chromium)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

web_dev_style: enhance <include> presubmit to account for <include src="..."/> <include src="..." /> R=tbreisacher@chromium.org BUG=393873 NOTRY=true Committed: https://crrev.com/e9c0681418502c97e56472c4a554b2735e79b0f8 Cr-Commit-Position: refs/heads/master@{#295796}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	chrome/browser/test_presubmit.py	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
	M	chrome/browser/web_dev_style/resource_checker.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585053003/20001

6 years, 3 months ago (2014-09-19 22:54:25 UTC) #4

commit-bot: I haz the power

Committed patchset #2 (id:20001) as b52c9b2bfcab66195adb03e256371d312a5c7552

6 years, 3 months ago (2014-09-19 22:55:44 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-19 22:56:17 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/e9c0681418502c97e56472c4a554b2735e79b0f8
Cr-Commit-Position: refs/heads/master@{#295796}