Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 585053002: Use RenderText vertical centering on Label and CanvasSkia text. (Closed)

Created:
6 years, 3 months ago by msw
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use RenderText vertical centering on Label and CanvasSkia text. Just use RenderText's cap-height vertical centering. Do not use one-off naive font-height vertical centering. BUG=411908 TEST=views::Label and gfx::Canvas::DrawString* text baselines look good and match Textfields. R=sky@chromium.org Committed: https://crrev.com/6060457aff422c0202da9fa0ed1f6243394a5fb1 Cr-Commit-Position: refs/heads/master@{#296008}

Patch Set 1 #

Patch Set 2 : Cleanup. #

Patch Set 3 : Update LabelTest expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -60 lines) Patch
M ui/gfx/canvas_skia.cc View 1 3 chunks +1 line, -14 lines 0 comments Download
M ui/views/controls/label.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/label_unittest.cc View 1 2 24 chunks +45 lines, -45 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
msw
Hey Scott, please take a look; thanks!
6 years, 3 months ago (2014-09-19 22:01:25 UTC) #2
sky
LGTM
6 years, 3 months ago (2014-09-22 15:51:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585053002/40001
6 years, 3 months ago (2014-09-22 17:15:51 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as d4e64dc8db9c9c303f18fa2d62961e57d006c2d5
6 years, 3 months ago (2014-09-22 17:46:06 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 17:46:49 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6060457aff422c0202da9fa0ed1f6243394a5fb1
Cr-Commit-Position: refs/heads/master@{#296008}

Powered by Google App Engine
This is Rietveld 408576698