Stop trying to use the italic version of the system font; it doesn't exist.

Stop trying to use the italic version of the system font; it doesn't exist.

With recent changes to ui::gfx::Font, attempting to actually draw non-existent font styles crashes.

BUG=171518, 314577
TEST=no crashes as in bug 314577
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233072

[Avi (use Gerrit), 2013-11-04 21:45:24]

Chris, I'm sending this to you because you owned bug 171518. I think this is the
most honest solution, since there is no italic version of the Mac system font,
so we shouldn't pretend there is.

(Mark, FYI.)

[csharp, 2013-11-04 21:49:55]

lgtm

[Avi (use Gerrit), 2013-11-04 21:53:38]

Evan, OWNERship.

[commit-bot: I haz the power, 2013-11-04 22:13:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/58503002/1

[Ilya Sherman, 2013-11-04 23:44:35]

On 2013/11/04 21:45:24, Avi wrote:
> Chris, I'm sending this to you because you owned bug 171518. I think this is
the
> most honest solution, since there is no italic version of the Mac system font,
> so we shouldn't pretend there is.

Lame.  Is there no reasonable alternate italic font that we can use?

[Avi (use Gerrit), 2013-11-05 00:04:55]

On 2013/11/04 23:44:35, Ilya Sherman wrote:
> On 2013/11/04 21:45:24, Avi wrote:
> > Chris, I'm sending this to you because you owned bug 171518. I think this is
> the
> > most honest solution, since there is no italic version of the Mac system
font,
> > so we shouldn't pretend there is.
> 
> Lame.  Is there no reasonable alternate italic font that we can use?

Lame, true, but in the previous incarnation of the code it would silently
discard the attributes anyway, so even if there were an italic or oblique
version it wouldn't have drawn. Now it obeys the reality of the actual fonts.

And there are plenty of fonts on the system with plenty of styles. Pick one :)

[commit-bot: I haz the power, 2013-11-05 00:42:37]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Nico, 2013-11-05 00:57:31]

lgtm

[commit-bot: I haz the power, 2013-11-05 01:07:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/58503002/1

[commit-bot: I haz the power, 2013-11-05 03:29:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/58503002/1

[commit-bot: I haz the power, 2013-11-05 07:34:01]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-11-05 15:07:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/58503002/1

[commit-bot: I haz the power, 2013-11-05 20:02:50]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[Avi (use Gerrit), 2013-11-05 20:07:19]

On 2013/11/05 20:02:50, I haz the power (commit-bot) wrote:
> Retried try job too often on linux_rel for step(s) browser_tests
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Really? ಠ_ಠ

[commit-bot: I haz the power, 2013-11-05 20:22:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/58503002/1

[commit-bot: I haz the power, 2013-11-05 20:33:09]

Change committed as 233072