Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 585023002: Fixes --output-format default case. (Closed)

Created:
6 years, 3 months ago by ariblue
Modified:
6 years, 3 months ago
Reviewers:
nednguyen, chrishenry
CC:
chromium-reviews, telemetry+watch_chromium.org, vogelheim
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixes --output-format default case. From python optparse docs for action='append': "It also means that if the default value is non-empty, the default elements will be present in the parsed value for the option, with any values from the command line appended after those default values:" So, to actually create a default, we have to set it later in CreateResults. Unfortunate, but true. Thanks vogelheim@ for catching this. BUG= Committed: https://crrev.com/ce5f7d429fde7fe62a83735658b54624b7077387 Cr-Commit-Position: refs/heads/master@{#295782}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tools/telemetry/telemetry/results/results_options.py View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ariblue
6 years, 3 months ago (2014-09-19 17:45:45 UTC) #2
chrishenry
lgtm Good to know.
6 years, 3 months ago (2014-09-19 19:04:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585023002/1
6 years, 3 months ago (2014-09-19 19:17:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as e542870377fdcbcdf5e39c0aa9811d099355288d
6 years, 3 months ago (2014-09-19 21:25:01 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 21:25:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce5f7d429fde7fe62a83735658b54624b7077387
Cr-Commit-Position: refs/heads/master@{#295782}

Powered by Google App Engine
This is Rietveld 408576698