Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 585003002: Reserves GWS experiment IDs for the TCP FastOpen experiment. (Closed)

Created:
6 years, 3 months ago by Jana
Modified:
6 years, 3 months ago
CC:
chromium-reviews, gayane -on leave until 09-2017
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reserves GWS experiment IDs for the TCP FastOpen experiment. BUG=413370 Committed: https://crrev.com/3561b3ab5dcbec4e2e8983d9099141d6e7aa06f8 Cr-Commit-Position: refs/heads/master@{#295736}

Patch Set 1 #

Patch Set 2 : Small nit in naming #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/common/variations/variation_ids.h View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Jana
Alexei, can you add an appropriate reviewer if you aren't the one I should be ...
6 years, 3 months ago (2014-09-19 17:13:56 UTC) #2
Alexei Svitkine (slow)
lgtm, +cc gayane who's in the process of moving this mapping to server-side, so that ...
6 years, 3 months ago (2014-09-19 17:15:03 UTC) #3
Jana
Thanks much! Submitting.
6 years, 3 months ago (2014-09-19 17:15:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585003002/1
6 years, 3 months ago (2014-09-19 17:17:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585003002/20001
6 years, 3 months ago (2014-09-19 17:25:50 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 5f7be9acbb6bf1567eba86fdda1271f651ed751d
6 years, 3 months ago (2014-09-19 18:08:22 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 18:09:45 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3561b3ab5dcbec4e2e8983d9099141d6e7aa06f8
Cr-Commit-Position: refs/heads/master@{#295736}

Powered by Google App Engine
This is Rietveld 408576698