Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 584953002: Add gpu_unittests to chromium_gpu_builder. (Closed)

Created:
6 years, 3 months ago by Jamie Madill
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add gpu_unittests to chromium_gpu_builder. This should be consistent with the other targets in the builder. BUG=391895 Committed: https://crrev.com/a7baf43f46e5367dc8f32db7f2eb8a201f4e746b Cr-Commit-Position: refs/heads/master@{#295745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/all.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jamie Madill
PTAL
6 years, 3 months ago (2014-09-19 16:51:44 UTC) #2
Zhenyao Mo
On 2014/09/19 16:51:44, Jamie Madill wrote: > PTAL LGTM
6 years, 3 months ago (2014-09-19 17:36:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584953002/1
6 years, 3 months ago (2014-09-19 17:37:57 UTC) #5
Ken Russell (switch to Gerrit)
Going forward let's move the build targets into the GPU recipe and remove the chromium_gpu_debug_builder ...
6 years, 3 months ago (2014-09-19 17:54:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8a6e8fac2b2df7c0e0bed3a265dcffd3d35f9128
6 years, 3 months ago (2014-09-19 18:34:48 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 18:35:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7baf43f46e5367dc8f32db7f2eb8a201f4e746b
Cr-Commit-Position: refs/heads/master@{#295745}

Powered by Google App Engine
This is Rietveld 408576698