Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 584943002: Make Map::Create always use the Object function, and remove the unused inobject properties (Closed)

Created:
6 years, 3 months ago by Toon Verwaest
Modified:
6 years, 3 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Make Map::Create always use the Object function, and remove the unused inobject properties BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24094

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -36 lines) Patch
M src/bootstrapper.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M src/factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/objects.cc View 1 chunk +13 lines, -17 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
PTAL
6 years, 3 months ago (2014-09-19 14:45:29 UTC) #2
Toon Verwaest
PTAL
6 years, 3 months ago (2014-09-19 14:51:17 UTC) #4
Jakob Kummerow
LGTM https://codereview.chromium.org/584943002/diff/1/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): https://codereview.chromium.org/584943002/diff/1/test/cctest/test-heap.cc#newcode995 test/cctest/test-heap.cc:995: Handle<JSFunction> object_ctor( I think we can drop this ...
6 years, 3 months ago (2014-09-19 14:56:05 UTC) #5
Toon Verwaest
Addressed
6 years, 3 months ago (2014-09-19 14:58:42 UTC) #6
Toon Verwaest
6 years, 3 months ago (2014-09-19 14:59:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24094 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698