LayoutTests/fast/dom/ping-attribute-dom-binding.html - Issue 58493002: Remove TreatNullAs=NullString for HTMLAnchorElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/ping-attribute-dom-binding.html

Issue 58493002: Remove TreatNullAs=NullString for HTMLAnchorElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix tests Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/element-attribute-js-null-expected.txt ('k') | LayoutTests/fast/dom/ping-attribute-dom-binding-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/ping-attribute-dom-binding.html

diff --git a/LayoutTests/fast/dom/ping-attribute-dom-binding.html b/LayoutTests/fast/dom/ping-attribute-dom-binding.html

index c627ba0aae7dbb8ef5ed7cf5990119b44fc56f84..2e913482d065e3fff8ecb18d30be636622ac517c 100644

--- a/LayoutTests/fast/dom/ping-attribute-dom-binding.html

+++ b/LayoutTests/fast/dom/ping-attribute-dom-binding.html

@@ -15,8 +15,8 @@ shouldBeEqualToString('anchor.ping', 'p1');

anchor.ping = 'p2';

shouldBeEqualToString('anchor.getAttribute("ping")', 'p2');

anchor.ping = null;

-shouldBeFalse('anchor.hasAttribute("ping")');

-shouldBeEqualToString('anchor.ping', '');

+shouldBeEqualToString('anchor.getAttribute("ping")', 'null');

+shouldBeEqualToString('anchor.ping', 'null');

var area = document.createElement('area');

shouldBeEqualToString('area.ping', '');