Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 58493002: Remove TreatNullAs=NullString for HTMLAnchorElement (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
CC:
blink-reviews, dglazkov+blink, arv+blink, Inactive, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove TreatNullAs=NullString for HTMLAnchorElement http://whatwg.org/html#htmlanchorelement http://whatwg.org/html#HTMLAnchorElement-partial The tests for the updated properties pass in Firefox Nightly, IE11 Release Preview and Opera 12.16, with these exceptions: Firefox reflects ping as a URL property, which is not per spec. IE11 reflects coords as '0,0,0,0' and shape as 'rect', while it doesn't support ping/download. Presto doesn't support ping/download. BUG=310298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161336

Patch Set 1 #

Patch Set 2 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -33 lines) Patch
M LayoutTests/fast/dom/element-attribute-js-null.html View 1 1 chunk +11 lines, -9 lines 0 comments Download
M LayoutTests/fast/dom/element-attribute-js-null-expected.txt View 1 1 chunk +11 lines, -9 lines 0 comments Download
M LayoutTests/fast/dom/ping-attribute-dom-binding.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/ping-attribute-dom-binding-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLAnchorElement.idl View 1 chunk +11 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
philipj_slow
7 years, 1 month ago (2013-11-05 08:51:07 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 1 month ago (2013-11-05 10:56:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/58493002/40001
7 years, 1 month ago (2013-11-05 13:22:30 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 14:09:17 UTC) #4
Message was sent while issue was closed.
Change committed as 161336

Powered by Google App Engine
This is Rietveld 408576698