Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 584923002: Revert of Make ONCCertificateImporter async. (Closed)

Created:
6 years, 3 months ago by eugenis
Modified:
6 years, 3 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, eroman, davemoore+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Make ONCCertificateImporter async. (patchset #1 id:1 of https://codereview.chromium.org/582413002/) Reason for revert: Use-after-free. https://code.google.com/p/chromium/issues/detail?id=415916 Original issue's description: > Make ONCCertificateImporter async. > > This prepares for the new CertDatabase keyed service, which will have stricter threading restrictions. https://codereview.chromium.org/419013003/ > Before, ONCCertificateImporter accessed the NSSCertDatabase from the UI thread and blocked on certificate store operations. > Now, the import itself is asychronous and calls back on completion. > > While there, this also removes the GMock of the importer. > > This is a reland of f08303014b165f6013fe33198cd798ebd9a4e925 > refs/heads/master@{#295534} > with the fixed destruction order in ONCCertificateImporterImplTest. > > The fix was reviewed in > https://codereview.chromium.org/589443002/ > > TBR=eroman@chromium.org > BUG=413219 > > Committed: https://crrev.com/3b4ba221657f6b27e2156818bc445c885d87fc0e > Cr-Commit-Position: refs/heads/master@{#295687} TBR=joaodasilva@chromium.org,eroman@chromium.org,pneubeck@chromium.org NOTREECHECKS=true NOTRY=true BUG=413219 Committed: https://crrev.com/3d9825c9ceda48206c96911e07b862609d19078f Cr-Commit-Position: refs/heads/master@{#295702}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -403 lines) Patch
M chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc View 18 chunks +77 lines, -95 lines 0 comments Download
M chrome/browser/chromeos/policy/user_network_configuration_updater.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/policy/user_network_configuration_updater.cc View 4 chunks +5 lines, -16 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 2 chunks +29 lines, -50 lines 0 comments Download
M chromeos/chromeos.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A chromeos/network/onc/mock_certificate_importer.h View 1 chunk +31 lines, -0 lines 0 comments Download
A chromeos/network/onc/mock_certificate_importer.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M chromeos/network/onc/onc_certificate_importer.h View 2 chunks +11 lines, -17 lines 0 comments Download
M chromeos/network/onc/onc_certificate_importer_impl.h View 4 chunks +27 lines, -38 lines 0 comments Download
M chromeos/network/onc/onc_certificate_importer_impl.cc View 13 chunks +80 lines, -118 lines 0 comments Download
M chromeos/network/onc/onc_certificate_importer_impl_unittest.cc View 12 chunks +54 lines, -64 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eugenis
Created Revert of Make ONCCertificateImporter async.
6 years, 3 months ago (2014-09-19 14:30:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584923002/1
6 years, 3 months ago (2014-09-19 14:31:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as bbde9050bca061f9297a4e6d36a14a9d1f8245cc
6 years, 3 months ago (2014-09-19 14:32:20 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 14:33:00 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d9825c9ceda48206c96911e07b862609d19078f
Cr-Commit-Position: refs/heads/master@{#295702}

Powered by Google App Engine
This is Rietveld 408576698