Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: public/web/WebViewClient.h

Issue 584893004: Use the pinch viewport offset for tap disambiguation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed the unit test for Android. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/tests/data/disambiguation_popup_200_by_800.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebViewClient.h
diff --git a/public/web/WebViewClient.h b/public/web/WebViewClient.h
index d71c1a9b40f20020876272baae53a8533962ac0d..10c1ac4a232b59ce07c2cda0f9965b291429b985 100644
--- a/public/web/WebViewClient.h
+++ b/public/web/WebViewClient.h
@@ -204,9 +204,15 @@ public:
// unless the view did not need a layout.
virtual void didUpdateLayout() { }
+ // FIXME: This is a deprecated method. Remove it after the chromium change
+ // that uses the second didTapMultipleTargets() propagates.
+ //
// Return true to swallow the input event if the embedder will start a disambiguation popup
virtual bool didTapMultipleTargets(const WebGestureEvent&, const WebVector<WebRect>& targetRects) { return false; }
+ // Return true to swallow the input event if the embedder will start a disambiguation popup
+ virtual bool didTapMultipleTargets(const WebSize& pinchViewportOffset, const WebRect& touchRect, const WebVector<WebRect>& targetRects) { return false; }
+
// Returns comma separated list of accept languages.
virtual WebString acceptLanguages() { return WebString(); }
« no previous file with comments | « Source/web/tests/data/disambiguation_popup_200_by_800.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698