Source/core/frame/PinchViewport.h - Issue 584893004: Use the pinch viewport offset for tap disambiguation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/PinchViewport.h

Issue 584893004: Use the pinch viewport offset for tap disambiguation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added a unit test. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/PinchViewport.h

diff --git a/Source/core/frame/PinchViewport.h b/Source/core/frame/PinchViewport.h

index fc6ae2fea5e582366b6278a0d639e34e3e1fac69..2a738a74e2fc1c976fa0661dcdbcbb1b578d54b6 100644

--- a/Source/core/frame/PinchViewport.h

+++ b/Source/core/frame/PinchViewport.h

@@ -80,7 +80,7 @@ public:

// coordinates are in partial CSS pixels.

void setLocation(const FloatPoint&);

void move(const FloatPoint&);

- FloatPoint location() const { return m_offset; } // used in unit tests

+ FloatPoint location() const { return m_offset; }

// Sets the size of the inner viewport when unscaled in CSS pixels.

// This will be clamped to the size of the outer viewport (the main frame).

« no previous file with comments | « no previous file | Source/web/WebViewImpl.cpp » ('j') | Source/web/tests/data/disambiguation_popup_200_by_800.html » ('J')