Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: public/web/WebViewClient.h

Issue 584893004: Use the pinch viewport offset for tap disambiguation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/tests/WebFrameTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebViewClient.h
diff --git a/public/web/WebViewClient.h b/public/web/WebViewClient.h
index bc0bb7edf1af646efd89055f61af4171e0399921..fadc699595ad56a192d74838a3a6f187900a8972 100644
--- a/public/web/WebViewClient.h
+++ b/public/web/WebViewClient.h
@@ -204,9 +204,15 @@ public:
// unless the view did not need a layout.
virtual void didUpdateLayout() { }
+ // TODO: This is a deprecated method. Remove it after the chromium change
+ // that uses the second didTapMultipleTargets() propagates.
+ //
// Return true to swallow the input event if the embedder will start a disambiguation popup
virtual bool didTapMultipleTargets(const WebGestureEvent&, const WebVector<WebRect>& targetRects) { return false; }
bokan 2014/09/23 15:38:22 I think the style is to keep param names unless th
timav 2014/09/23 22:30:07 Done.
+ // Return true to swallow the input event if the embedder will start a disambiguation popup
+ virtual bool didTapMultipleTargets(const WebSize&, const WebRect&, const WebVector<WebRect>& targetRects) { return false; }
+
// Returns comma separated list of accept languages.
virtual WebString acceptLanguages() { return WebString(); }
« no previous file with comments | « Source/web/tests/WebFrameTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698