Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: public/web/WebViewClient.h

Issue 584893004: Use the pinch viewport offset for tap disambiguation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added a unit test. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 // Called when a new node gets focused. 197 // Called when a new node gets focused.
198 virtual void focusedNodeChanged(const WebNode&) { } 198 virtual void focusedNodeChanged(const WebNode&) { }
199 199
200 // Indicates two things: 200 // Indicates two things:
201 // 1) This view may have a new layout now. 201 // 1) This view may have a new layout now.
202 // 2) Calling layout() is a no-op. 202 // 2) Calling layout() is a no-op.
203 // After calling WebWidget::layout(), expect to get this notification 203 // After calling WebWidget::layout(), expect to get this notification
204 // unless the view did not need a layout. 204 // unless the view did not need a layout.
205 virtual void didUpdateLayout() { } 205 virtual void didUpdateLayout() { }
206 206
207 // TODO: This is a deprecated method. Remove it after the chromium change
jamesr 2014/09/23 23:25:16 s/TODO/FIXME/
208 // that uses the second didTapMultipleTargets() propagates.
209 //
207 // Return true to swallow the input event if the embedder will start a disam biguation popup 210 // Return true to swallow the input event if the embedder will start a disam biguation popup
208 virtual bool didTapMultipleTargets(const WebGestureEvent&, const WebVector<W ebRect>& targetRects) { return false; } 211 virtual bool didTapMultipleTargets(const WebGestureEvent&, const WebVector<W ebRect>& targetRects) { return false; }
209 212
213 // Return true to swallow the input event if the embedder will start a disam biguation popup
214 virtual bool didTapMultipleTargets(const WebSize& pinchViewportOffset, const WebRect& touchRect, const WebVector<WebRect>& targetRects) { return false; }
215
210 // Returns comma separated list of accept languages. 216 // Returns comma separated list of accept languages.
211 virtual WebString acceptLanguages() { return WebString(); } 217 virtual WebString acceptLanguages() { return WebString(); }
212 218
213 219
214 // Session history ----------------------------------------------------- 220 // Session history -----------------------------------------------------
215 221
216 // Tells the embedder to navigate back or forward in session history by 222 // Tells the embedder to navigate back or forward in session history by
217 // the given offset (relative to the current position in session 223 // the given offset (relative to the current position in session
218 // history). 224 // history).
219 virtual void navigateBackForwardSoon(int offset) { } 225 virtual void navigateBackForwardSoon(int offset) { }
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
307 // Informs the browser that the draggable regions have been updated. 313 // Informs the browser that the draggable regions have been updated.
308 virtual void draggableRegionsChanged() { } 314 virtual void draggableRegionsChanged() { }
309 315
310 protected: 316 protected:
311 ~WebViewClient() { } 317 ~WebViewClient() { }
312 }; 318 };
313 319
314 } // namespace blink 320 } // namespace blink
315 321
316 #endif 322 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698