Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 584893002: mojo: Add deserialization to python structs. (Closed)

Created:
6 years, 3 months ago by qsr
Modified:
6 years, 3 months ago
Reviewers:
Chris Masone, sdefresne
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mojo: Add deserialization to python structs. This is a reland of https://codereview.chromium.org/588493002 using buffer on bytearray before trying to call unpack_from because python 2.7.3 and earlier doesn't handle unpacking a bytearray directly. BUG=415491 R=sdefresne@chromium.org,cmasone@chromium.org Committed: https://crrev.com/25606073cbdfc4772a0caaa23a624a83293fbadc Cr-Commit-Position: refs/heads/master@{#295716}

Patch Set 1 #

Patch Set 2 : With the patch #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -29 lines) Patch
M mojo/public/python/mojo/bindings/descriptor.py View 18 chunks +132 lines, -19 lines 0 comments Download
M mojo/public/python/mojo/bindings/reflection.py View 1 chunk +8 lines, -0 lines 0 comments Download
M mojo/public/python/mojo/bindings/serialization.py View 1 3 chunks +34 lines, -6 lines 2 comments Download
M mojo/python/tests/bindings_serialization_deserialization_unittest.py View 3 chunks +82 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
qsr
Ok, 3rd time is the charm. This time I downloaded and install python 2.7.5, 2.7.4 ...
6 years, 3 months ago (2014-09-19 14:02:55 UTC) #1
sdefresne
https://codereview.chromium.org/584893002/diff/20001/mojo/public/python/mojo/bindings/serialization.py File mojo/public/python/mojo/bindings/serialization.py (right): https://codereview.chromium.org/584893002/diff/20001/mojo/public/python/mojo/bindings/serialization.py#newcode82 mojo/public/python/mojo/bindings/serialization.py:82: if not isinstance(data, buffer): Why not simply "data = ...
6 years, 3 months ago (2014-09-19 15:18:31 UTC) #2
sdefresne
lgtm
6 years, 3 months ago (2014-09-19 15:18:37 UTC) #3
qsr
https://codereview.chromium.org/584893002/diff/20001/mojo/public/python/mojo/bindings/serialization.py File mojo/public/python/mojo/bindings/serialization.py (right): https://codereview.chromium.org/584893002/diff/20001/mojo/public/python/mojo/bindings/serialization.py#newcode82 mojo/public/python/mojo/bindings/serialization.py:82: if not isinstance(data, buffer): On 2014/09/19 15:18:30, sdefresne wrote: ...
6 years, 3 months ago (2014-09-19 15:45:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584893002/20001
6 years, 3 months ago (2014-09-19 15:46:41 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 695b1655fdfff3e060aaedffee15ff69428b7d1c
6 years, 3 months ago (2014-09-19 16:12:46 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 16:13:19 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/25606073cbdfc4772a0caaa23a624a83293fbadc
Cr-Commit-Position: refs/heads/master@{#295716}

Powered by Google App Engine
This is Rietveld 408576698