Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 584843002: Remove a couple of deprecated APIs that moved to Isolate (Closed)

Created:
6 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Project:
v8
Visibility:
Public.

Description

Remove a couple of deprecated APIs that moved to Isolate Embedders should either pass the information to via Isolate::CreateParams or use Isolate::SetStackLimit where appropriate BUG=none R=svenpanne@chromium.org LOG=y Committed: https://code.google.com/p/v8/source/detail?r=24080

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -107 lines) Patch
M include/v8.h View 2 chunks +0 lines, -54 lines 0 comments Download
M src/api.cc View 3 chunks +13 lines, -53 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 3 months ago (2014-09-19 11:04:49 UTC) #1
Sven Panne
lgtm
6 years, 3 months ago (2014-09-19 11:23:38 UTC) #2
jochen (gone - plz use gerrit)
6 years, 3 months ago (2014-09-19 11:28:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24080 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698