Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: tools/gyp/xcode.gypi

Issue 584813002: Avoid undefined variable in gyp files. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gyp/configurations_xcode.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gyp/xcode.gypi
diff --git a/tools/gyp/xcode.gypi b/tools/gyp/xcode.gypi
index 6197887d6faf1bee3563a4fbef76cd0db936de8a..1c0faff247baa7c5f9bcdb747a70dcdaf23034d1 100644
--- a/tools/gyp/xcode.gypi
+++ b/tools/gyp/xcode.gypi
@@ -52,5 +52,11 @@
# Perhaps we should set it to @rpath instead. See
# http://developer.apple.com/library/mac/#documentation/DeveloperTools/Conceptual/DynamicLibraries/100-Articles/RunpathDependentLibraries.html#//apple_ref/doc/uid/TP40008306-SW1
'INSTALL_PATH': '$(TARGET_BUILD_DIR)',
+
+ # This must go here because mac_deployment_target is defined in this file,
+ # which is only included on mac, and configurations_xcode.gypi is included
+ # on all platforms, so it would be an undefined variable there.
+ # Move this to configurations_xcode if we start including it only on mac.
+ 'MACOSX_DEPLOYMENT_TARGET': '<(mac_deployment_target)',
},
}
« no previous file with comments | « tools/gyp/configurations_xcode.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698