Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 584753003: Move content_settings_observable_provider and content_seettings_origin_identifier_value_map (Closed)

Created:
6 years, 3 months ago by Jun Mukai
Modified:
6 years, 3 months ago
CC:
blundell, chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, markusheintz_, vabr (Chromium), vasilii
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move content_settings_observable_provider and content_seettings_origin_identifier_value_map BUG=384870 R=jochen@chromium.org TEST=build succeeds Committed: https://crrev.com/9afeee5d20ca3d8e2a5acb0eeb71428a6f2a4e82 Cr-Commit-Position: refs/heads/master@{#296024}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -422 lines) Patch
M chrome/browser/content_settings/content_settings_custom_extension_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_default_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_internal_extension_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/content_settings_mock_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/content_settings/content_settings_observable_provider.h View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/content_settings/content_settings_observable_provider.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/content_settings/content_settings_origin_identifier_value_map.h View 1 chunk +0 lines, -127 lines 0 comments Download
D chrome/browser/content_settings/content_settings_origin_identifier_value_map.cc View 1 chunk +0 lines, -186 lines 0 comments Download
M chrome/browser/content_settings/content_settings_origin_identifier_value_map_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_policy_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/content_settings_pref_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M components/content_settings.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M components/content_settings/core/browser/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
A + components/content_settings/core/browser/content_settings_observable_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/content_settings/core/browser/content_settings_observable_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/content_settings/core/browser/content_settings_origin_identifier_value_map.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/content_settings/core/browser/content_settings_origin_identifier_value_map.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Jun Mukai
6 years, 3 months ago (2014-09-19 01:58:46 UTC) #1
jochen (gone - plz use gerrit)
+vabr, please review happy to rubberstamp once you're done
6 years, 3 months ago (2014-09-19 13:29:17 UTC) #3
vabr (Chromium)
LGTM, nothing controversial here, just the move. Thanks Jun! Vaclav
6 years, 3 months ago (2014-09-19 14:10:25 UTC) #4
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-22 09:41:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584753003/1
6 years, 3 months ago (2014-09-22 18:23:02 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as cbe5df14351deba039ef1d406a60c80dc4b3715e
6 years, 3 months ago (2014-09-22 19:10:58 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 19:11:51 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9afeee5d20ca3d8e2a5acb0eeb71428a6f2a4e82
Cr-Commit-Position: refs/heads/master@{#296024}

Powered by Google App Engine
This is Rietveld 408576698