Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 584753002: Revert of GCM: D-Bus methods for wake-on-packet (Closed)

Created:
6 years, 3 months ago by Mr4D (OOO till 08-26)
Modified:
6 years, 3 months ago
CC:
Chirantan Ekbote, chromium-reviews, oshima+watch_chromium.org, snanda_chromium.ort, stevenjb+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of GCM: D-Bus methods for wake-on-packet (patchset #15 id:280001 of https://codereview.chromium.org/409883006/) Reason for revert: See issue https://code.google.com/p/chromium/issues/detail?id=415281 I bissected chrome to this patch and figured that this is causing chrome to crash. Sorry. Original issue's description: > GCM: D-Bus methods for wake-on-packet > > Program the NIC to wake-on-packet for packets arriving from > the GCM server. Chrome notifies the connection manager (shill) > by calling D-Bus methods. The return status indicates if the > operation succeeded or not (depending on hardware support and > the type of connection). > > Keywords: wowlan, wake-on-lan, wake-on-wlan > > BUG=360295 > TEST=verified dbus methods are called, and packets are sent on the > TEST=connection passed to the methods. Also verified that shill > TEST=programs the NIC correctly, and packets wake up the device. > > Committed: https://crrev.com/88a95a70fa94bb578b371490d0f9868584b7096e > Cr-Commit-Position: refs/heads/master@{#294936} TBR=derat@chromium.org,fgorski@chromium.org,stevenjb@chromium.org,zea@chromium.org,scheib@chromium.org,yoz@chromium.org,semenzato@chromium.org NOTREECHECKS=true NOTRY=true BUG=360295 Committed: https://crrev.com/8e7b4ff4742ed5f78fa57550af1fb4cfc5705372 Cr-Commit-Position: refs/heads/master@{#295592}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -226 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_gcm_app_handler_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
D chrome/browser/services/gcm/chromeos_gcm_connection_observer.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/services/gcm/chromeos_gcm_connection_observer.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service_unittest.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/dbus/fake_shill_manager_client.h View 2 chunks +0 lines, -16 lines 0 comments Download
M chromeos/dbus/fake_shill_manager_client.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M chromeos/dbus/mock_shill_manager_client.h View 2 chunks +0 lines, -12 lines 0 comments Download
M chromeos/dbus/shill_manager_client.h View 2 chunks +12 lines, -32 lines 0 comments Download
M chromeos/dbus/shill_manager_client.cc View 2 chunks +0 lines, -38 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mr4D (OOO till 08-26)
Created Revert of GCM: D-Bus methods for wake-on-packet
6 years, 3 months ago (2014-09-18 23:08:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584753002/1
6 years, 3 months ago (2014-09-18 23:12:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 24316b5b5c6eb06c98bdd7b592b4bfa605cd6e0a
6 years, 3 months ago (2014-09-18 23:14:25 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 23:15:27 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e7b4ff4742ed5f78fa57550af1fb4cfc5705372
Cr-Commit-Position: refs/heads/master@{#295592}

Powered by Google App Engine
This is Rietveld 408576698