Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 584743003: 4th attempt to land change to remove NativeViewportService and (Closed)

Created:
6 years, 3 months ago by DaveMoore
Modified:
6 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

4th attempt to land change to remove NativeViewportService and ViewManager from mojo_shell. Original cl was https://codereview.chromium.org/477923004/ Failure was http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%284%29/builds/28279 TBR=ben@chromium.org BUG= Committed: https://crrev.com/fa74b605590d223ce5b80e43aeef444e9a201f30 Cr-Commit-Position: refs/heads/master@{#295876}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -176 lines) Patch
M mojo/aura/aura_init.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo.gyp View 10 chunks +12 lines, -35 lines 0 comments Download
M mojo/mojo_examples.gypi View 5 chunks +1 line, -5 lines 0 comments Download
M mojo/mojo_services.gypi View 1 11 chunks +34 lines, -13 lines 0 comments Download
M mojo/services/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download
M mojo/services/html_viewer/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/html_viewer.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M mojo/services/native_viewport/BUILD.gn View 1 2 chunks +18 lines, -10 lines 0 comments Download
M mojo/services/native_viewport/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/services/native_viewport/main.cc View 1 chunk +102 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/BUILD.gn View 1 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/BUILD.gn View 1 chunk +7 lines, -8 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_test_suite.cc View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/services/public/interfaces/native_viewport/native_viewport.mojom View 1 chunk +7 lines, -0 lines 0 comments Download
M mojo/services/view_manager/BUILD.gn View 1 4 chunks +14 lines, -11 lines 0 comments Download
M mojo/services/view_manager/ids.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 3 chunks +11 lines, -7 lines 0 comments Download
M mojo/services/window_manager/BUILD.gn View 1 1 chunk +0 lines, -6 lines 0 comments Download
M mojo/shell/BUILD.gn View 5 chunks +5 lines, -29 lines 0 comments Download
M mojo/shell/context.cc View 4 chunks +5 lines, -25 lines 0 comments Download
M mojo/shell/desktop/mojo_main.cc View 3 chunks +14 lines, -16 lines 0 comments Download
M mojo/shell/in_process_dynamic_service_runner.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
DaveMoore
Rebase
6 years, 3 months ago (2014-09-20 14:29:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584743003/20001
6 years, 3 months ago (2014-09-20 15:10:56 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001) as a71695721eb3f4f3dc7564bba562da8dfc119c1c
6 years, 3 months ago (2014-09-20 15:15:17 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 15:15:47 UTC) #5
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fa74b605590d223ce5b80e43aeef444e9a201f30
Cr-Commit-Position: refs/heads/master@{#295876}

Powered by Google App Engine
This is Rietveld 408576698